WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16423 closed defect (bug) (fixed)

Localization: The word "Format" is the same in the post format and tinymce

Reported by: settle Owned by:
Milestone: 3.1 Priority: normal
Severity: trivial Version: 3.1
Component: I18N Keywords: has-patch i18n-change commit
Focuses: Cc:

Description

/wp-includes/taxonomy.php

90.			'name' => __( 'Format' ),
91.			'singular_name' => __( 'Format' ),

/wp-includes/js/tinymce/langs/wp-langs.php

185. block:"' . mce_escape( __('Format') ) . '",

/wp-admin/edit-form-advanced

112.	add_meta_box( 'formatdiv', __('Format'), 'post_format_meta_box', $post_type, 'side', 'core' );

When updating from sources, poedit treats with Post Format and Tinymce Format like they are the same. Can you make them different from each other, using _x or something else (I have no knowlidge in coding).

Attachments (2)

16423.patch (508 bytes) - added by SergeyBiryukov 3 years ago.
16423.diff (1.2 KB) - added by scribu 3 years ago.

Download all attachments as: .zip

Change History (15)

SergeyBiryukov3 years ago

comment:1 SergeyBiryukov3 years ago

  • Keywords has-patch added

scribu3 years ago

comment:2 scribu3 years ago

Missed one, Sergey. See 16423.diff

Would it make sense to add different contexts for 'name' and 'singular_name' ?

comment:3 scribu3 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:4 scribu3 years ago

  • Type changed from enhancement to defect (bug)

comment:5 markjaquith3 years ago

Would it make sense to add different contexts for 'name' and 'singular_name' ?

Doesn't seem necessary. They're identical, by default, with identical meaning.

comment:6 nacin3 years ago

See #16172 for why they're the same. I did it to avoid a string change.

Though that is perhaps desired due to the exclusive nature of the taxonomy. Think about it being used in get_the_taxonomies() for example: "Format: Aside" rather than "Formats:".

comment:7 scribu3 years ago

  • Keywords commit added

Ok, commit ready then.

comment:8 nacin3 years ago

  • Keywords i18n-change added; commit removed

Well at this point, it is now a string change, so we should consider.

comment:9 follow-up: nacin3 years ago

  • Keywords commit added

Currently get_the_taxonomies uses $taxonomy->label, which is an alias for $taxonomy->labels->name. It avoids singular_name even when the count is 1. Perhaps this would be a good enhancement separately, but for now, I'm indeed fine with 'Format' for both name and singular_name.

This would be our first string change in the cycle. That this is a request from translators for more context, I'm fine with it from that perspective. We need to post to wppolyglots when done.

comment:10 in reply to: ↑ 9 SergeyBiryukov3 years ago

Replying to nacin:

This would be our first string change in the cycle.

I think the first one was in [17233] (which is already reported to wppolyglots).

comment:11 nacin3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17372]) Add context to 'Format' string. props scribu, SergeyBiryukov, fixes #16423 for trunk.

comment:12 SergeyBiryukov3 years ago

As per Mark's post on wpdevel:

So until 3.1 launches, trunk and branches/3.1 should remain identical.

Shouldn't 16423.diff be applied to branches/3.1 as well?

comment:13 nacin3 years ago

(In [17373]) Add context to 'Format' string. props scribu, SergeyBiryukov, fixes #16423 for the 3.1 branch.

Note: See TracTickets for help on using tickets.