WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16426 closed enhancement (fixed)

jQuery 1.5.2

Reported by: duck_ Owned by:
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: External Libraries Keywords: has-patch needs-testing
Focuses: Cc:

Attachments (5)

16426.diff (159.4 KB) - added by c3mdigital 3 years ago.
jquery.diff (160.3 KB) - added by niallkennedy 3 years ago.
jQuery 1.5.1 diff against 1.4.4
t16426-jquery-144-151.diff (161.0 KB) - added by demetris 3 years ago.
Updates jQuery from 1.4.4 to 1.5.1
t16426-jquery-144-152.diff (161.6 KB) - added by JDTrower 3 years ago.
Updates jQuery from 1.4.4 to 1.5.2
t16426-jquery-144-152.2.diff (161.6 KB) - added by demetris 3 years ago.
Updates jQuery from 1.4.4 to 1.5.2

Download all attachments as: .zip

Change History (35)

c3mdigital3 years ago

comment:1 c3mdigital3 years ago

  • Keywords has-patch added
  • Type changed from defect (bug) to enhancement
  • Version set to 3.1

comment:2 c3mdigital3 years ago

  • Cc chris@… added

comment:3 c3mdigital3 years ago

Patch added

comment:4 markjaquith3 years ago

  • Keywords 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

We'll get this in 3.2, early on. Too late for 3.1.

comment:5 jkudish3 years ago

+1 on this one, glad it's getting into 3.2

comment:6 ramoonus3 years ago

jQuery 1.5.1 (bugfix release) is planned for next thursday

comment:7 ramoonus3 years ago

  • Summary changed from jQuery 1.5 to jQuery 1.5.1

jQuery 1.5.1 has been released yesterday.

comment:8 filosofo3 years ago

Related: #16508

niallkennedy3 years ago

jQuery 1.5.1 diff against 1.4.4

comment:9 ryan3 years ago

  • Keywords 3.2-early removed
  • Milestone changed from Future Release to 3.2

comment:10 ramoonus3 years ago

  • Keywords close added

comment:11 ramoonus3 years ago

  • Keywords close removed

oops

demetris3 years ago

Updates jQuery from 1.4.4 to 1.5.1

comment:12 hebbet3 years ago

  • Keywords needs-patch added; has-patch removed
  • Summary changed from jQuery 1.5.1 to jQuery 1.5.2

JDTrower3 years ago

Updates jQuery from 1.4.4 to 1.5.2

comment:13 JDTrower3 years ago

  • Keywords has-patch added; needs-patch removed

demetris3 years ago

Updates jQuery from 1.4.4 to 1.5.2

comment:14 demetris3 years ago

JDTrower, you forgot the noConflict() bit we add at the end. :-)

comment:15 JDTrower3 years ago

You're right. I did. I was running a comparison between your diff and mine to figure out what was different. noConflict() slipped my mind to make sure I added it back.

comment:16 azaozz3 years ago

The patch looks good. However, did anybody test if it breaks something? Currently tracking several issues that came from updating jQuery and jQUI in 3.1, one quite annoying that can make the Edit Page screen unusable in IE7/8.

Perhaps some (light) testing is in order before even thinking of updating. Unfortunately there's not much automated tests that we can do on UI sortables, etc. so it seems it has to be done by hand. A good testing install would have 300-400 Posts, 300-400 Pages, 200-300 Tags and 200-300 Cats. Main things to test:

  • All draggable, droppable, sortable elements work as expected on all pages.
  • Everything on the Add/Edit Post/Page screens works as expected.
  • Any bugs are reported on the jQuery and jQUI tracs.

Testing has to be done in all currently supported browsers: IE 7, 8, 9; FF 3.6, 4.0; Safari 5, Chrome 10, Opera 10.

Last edited 3 years ago by azaozz (previous) (diff)

comment:17 ramoonus3 years ago

  • Keywords needs-testing added

and opera 11

comment:18 JDTrower3 years ago

  • Component changed from External Libraries to Export
  • Owner set to JDTrower
  • Status changed from new to reviewing

I'm still planning on testing the other browsers, but have tested in FF 4.0 and the same problem reported on #16955 still occurs in 3.2-bleeding with jQuery updated to 1.5.2 with this patch.

comment:19 JDTrower3 years ago

  • Component changed from Export to External Libraries
  • Owner JDTrower deleted

Not sure how I got set to owner or how the status or component got changed, but trying to fix that now.

comment:20 JDTrower3 years ago

I have tested the latest patch in IE 8, IE 9, FF 3.6, FF 4.0, Safari 5, Chrome 10, Opera 10, and Opera 11 on Windows Vista and Windows 7 computers and I didn't notice any bugs. Everything worked as expected. This was done on a test install with 311 posts, 387 pages, 216 categories, 408 tags, and 401 comments.

Last edited 3 years ago by JDTrower (previous) (diff)

comment:21 JDTrower3 years ago

Should have mentioned that IE 8 and 9, I did encounter problems that are listed in detail on #17070. But other than that ticket and #16955 (which the fix has been applied upstream and just waiting on the release of jQuery UI 1.8.12) everything else worked fine for me.

comment:22 follow-up: demetris3 years ago

Thank you for you taking the time to do this, JDTrower.

By the way, nacin suggested the other day on the IRC channel that we should make a checklist for testing jQuery and jQuery UI updates. I think this is a good idea, as it would make testing better and easier: you open the checklist, launch the supported browsers, and you start going through the checklist point by point.

comment:23 in reply to: ↑ 22 JDTrower3 years ago

Replying to demetris:

Thank you for you taking the time to do this, JDTrower.

By the way, nacin suggested the other day on the IRC channel that we should make a checklist for testing jQuery and jQuery UI updates. I think this is a good idea, as it would make testing better and easier: you open the checklist, launch the supported browsers, and you start going through the checklist point by point.

You're welcome demetris.

I agree that that is a good idea. It would make testing not only better and easier, but also more consistent. I assume a checklist like that would be a Codex page or would it be located somewhere else?

comment:25 hebbet3 years ago

jQuery 1.6 is currently planned for end of April.
Feature freeze of Wordpress 3.2 is schedueled for April 30, so i think it is too late for getting jQuery 1.6 into Wordpress 3.2

comment:26 scribu3 years ago

@JDTrower: Yes, a Codex page would be a good start.

@ramoonus: jQuery 1.6 doesn't sound like a good idea for WP 3.2.

Last edited 3 years ago by scribu (previous) (diff)

comment:27 ramoonus3 years ago

i know its slightly offtopic
but i have developed a very simple plugin ( http://wordpress.org/extend/plugins/jquery-updater/ )
which replaces the default WP jQuery with the latest stable version
but only for the front-end
ideal for testing your websites content with a "future" WP jQuery version

comment:28 azaozz3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [17725]) jQuery 1.5.2, props JDTrower demetris, fixes #16426

comment:29 azaozz3 years ago

In [17777]:

Add quotes to [value="some"] selectors, see #16426

comment:30 scribu3 years ago

For jQuery 1.6: #17311

Note: See TracTickets for help on using tickets.