WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #16434, comment 97


Ignore:
Timestamp:
03/01/2012 11:11:12 AM (6 years ago)
Author:
ocean90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16434, comment 97

    initial v1  
    33 - `echo <<<` ... do we really want this?
    44 - instead of FAVICON_SIZE I would prefer `apply_filters( 'favicon_size', 32 )`
    5  - Because the image will be uploaded to the media library, the image should be marked, see `_media_states`
    6  - If I delete the favicon from the media library the options should get reset accordingly (like for theme mods `_delete_attachment_theme_mod`)
     5 - Because the image will be uploaded to the media library, the image should be marked, see `_media_states()`
     6 - If I delete the favicon from the media library the options should get reset accordingly (like for theme mods `_delete_attachment_theme_mod()`)
    77 - And should we delete the original image after cropping?