<input> is not a block-level element, should be removed from wpautop()

[ABTOP]

The brief explanation of the problem:
​http://wordpress.org/support/topic/extra-in-get_the_password_form

Upon further investigation, I was able to determine that the culprit is actually the wpautop() function (file wp-includes/formatting.php), line 188 - $allblocks - as of wp3.1 RC3:

function wpautop($pee, $br = 1) {

	if ( trim($pee) === '' )
		return '';
	$pee = $pee . "\n"; // just to make things a little easier, pad the end
	$pee = preg_replace('|<br />\s*<br />|', "\n\n", $pee);
	// Space things out a little
	$allblocks = '(?:table|thead|tfoot|caption|col|colgroup|tbody|tr|td|th|div|dl|dd|dt|ul|ol|li|pre|select|option|form|map|area|blockquote|address|math|style|input|p|h[1-6]|hr|fieldset|legend|section|article|aside|hgroup|header|footer|nav|figure|figcaption|details|menu|summary)';

The output from get_the_password_form() goes through wpautop() and extra <br /> tags are inserted before each <input> tag.

I hope this is not a feature.

[nacin]

Kinda funky, but patch looks proper.

[nacin]

After IRC discussion, this approach isn't right.

Rather, the line breaks are due to input being considered a block-level element. this is wrong.

See #3054 for where this occurred.

Since this is so edge (doesn't even result in bad HTML) and technically requires a more comprehensive fix for something changed 5 or 6 years ago — instant punt.

[SergeyBiryukov]

Closed #19934 as duplicate.

[kurtpayne]

Unit test ​changeset 560 tests for this.

[nacin]

In [20078]:

<input> is not a block-level element; do not treat it like one in wpautop(). props SergeyBiryukov. props kurtpayne for the unit test. fixes #16456.