Opened 14 years ago
Closed 11 years ago
#16468 closed defect (bug) (fixed)
Twenty Ten: 404 page with /page/2 shows page number
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | minor | Version: | 3.0 |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
In 2010, there's a custom part of the title that shows " | Page 2" etc for paged posts.
Yet, even if it's a 404, it still shows this if there's a $page or $paged variable.
e.g. /2012/04/page/2 (picked to obviously 404) is: Page not found | robinadr | Page 2 on my site.
Checked trunk, same problem there.
Attachments (4)
Change History (17)
#3
@
14 years ago
- Cc robin.adr@… removed
Yeah, having to global those variables and do the max() handling in a theme seems clumsy.
How about is_paged() and get_current_page_number()?
#4
@
14 years ago
We already have is_paged(), which checks the is_paged query flag. I think we need more for when it is instead the page
query variable.
This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.
11 years ago
This ticket was mentioned in IRC in #wordpress-dev by doc-bot. View the logs.
11 years ago
#8
@
11 years ago
- Component changed from Themes to Bundled Theme
- Keywords needs-refresh added
- Milestone changed from Awaiting Review to Future Release
- Summary changed from 404 page with /page/2 shows page # to Twenty Ten: 404 page with /page/2 shows page number
#10
@
11 years ago
- Keywords commit added; needs-refresh removed
- Milestone changed from Future Release to 4.0
Tested at WordCamp Switzerland contributor day.
It'd be great to have a helper to prevent the page/paged conditional as well as the max() call. Like get_queried_page_num() and has_multiple_pages() (for other checks in the theme).