WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 months ago

#16468 new defect (bug)

Twenty Ten: 404 page with /page/2 shows page number

Reported by: rob1n Owned by:
Milestone: Future Release Priority: normal
Severity: minor Version: 3.0
Component: Bundled Theme Keywords: has-patch needs-refresh
Focuses: Cc:

Description

In 2010, there's a custom part of the title that shows " | Page 2" etc for paged posts.

Yet, even if it's a 404, it still shows this if there's a $page or $paged variable.

e.g. /2012/04/page/2 (picked to obviously 404) is: Page not found | robinadr | Page 2 on my site.

Checked trunk, same problem there.

Attachments (2)

paged-404.diff (500 bytes) - added by rob1n 3 years ago.
16468.diff (931 bytes) - added by MikeHansenMe 8 weeks ago.
Refresh with brackets

Download all attachments as: .zip

Change History (10)

rob1n3 years ago

comment:1 rob1n3 years ago

  • Cc robin.adr@… added

comment:2 nacin3 years ago

  • Version changed from 3.1 to 3.0

It'd be great to have a helper to prevent the page/paged conditional as well as the max() call. Like get_queried_page_num() and has_multiple_pages() (for other checks in the theme).

comment:3 rob1n3 years ago

  • Cc robin.adr@… removed

Yeah, having to global those variables and do the max() handling in a theme seems clumsy.

How about is_paged() and get_current_page_number()?

comment:4 nacin3 years ago

We already have is_paged(), which checks the is_paged query flag. I think we need more for when it is instead the page query variable.

comment:5 scribu19 months ago

Related: #16973

comment:6 ircbot2 months ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

comment:7 ircbot2 months ago

This ticket was mentioned in IRC in #wordpress-dev by doc-bot. View the logs.

comment:8 lancewillett2 months ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from 404 page with /page/2 shows page # to Twenty Ten: 404 page with /page/2 shows page number

MikeHansenMe8 weeks ago

Refresh with brackets

Note: See TracTickets for help on using tickets.