WordPress.org

Make WordPress Core

Opened 9 years ago

Last modified 5 months ago

#16478 reviewing defect (bug)

"Get Shortlink" button disappears if you edit the permalink

Reported by: solarissmoke Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Editor Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Go to edit a post and change the permalink. The "Get Shortlink" button is overwritten by the AJAX response. I think it's a simple case of moving where the shortlink is added, see patch.

Attachments (3)

16478.diff (2.0 KB) - added by solarissmoke 9 years ago.
16478-better.diff (4.1 KB) - added by solarissmoke 9 years ago.
16478-3.patch (2.0 KB) - added by aubreypwd 6 years ago.
Moved Get Shortlink to get_sample_permalink_html

Download all attachments as: .zip

Change History (19)

@solarissmoke
9 years ago

#1 @solarissmoke
9 years ago

  • Keywords has-patch added

#2 @solarissmoke
9 years ago

Actually here is a better way - no need to overwrite static data with AJAX. This would also resolve #16477.

#3 @navjotjsingh
7 years ago

  • Cc navjotjsingh@… added

This ticket was mentioned in IRC in #wordpress-dev by aubreypwd. View the logs.


6 years ago

@aubreypwd
6 years ago

Moved Get Shortlink to get_sample_permalink_html

#5 @aubreypwd
6 years ago

Okay, got a patch that keeps "Get Shortlink" persistent when editing. This does not fix #16477 which will have it's own patch.

This ticket was mentioned in IRC in #wordpress-dev by aubreypwd. View the logs.


6 years ago

#7 @aubreypwd
6 years ago

Last edited 6 years ago by aubreypwd (previous) (diff)

This ticket was mentioned in IRC in #wordpress-dev by aubreypwd. View the logs.


6 years ago

#9 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.9

Moving to 3.9 per 7:ticket:22980.

#10 @nacin
6 years ago

  • Keywords 4.0-early added
  • Milestone changed from 3.9 to Future Release

Ran out of time, moving to 4.0.

#11 @SergeyBiryukov
5 years ago

#31933 was marked as a duplicate.

#12 follow-up: @ericlewis
4 years ago

Given that the Get Shortlink button is hidden by default since r34556, are we interested in fixing this?

#13 in reply to: ↑ 12 @DrewAPicture
4 years ago

Replying to ericlewis:

Given that the Get Shortlink button is hidden by default since r34556, are we interested in fixing this?

Hidden or not, if we're still displaying it in some fashion and it is still a part of core, we should still be committed to ensuring a good experience.

#14 @iseulde
4 years ago

  • Keywords 4.0-early removed

#15 @swissspidy
3 years ago

  • Owner set to swissspidy
  • Status changed from new to reviewing

#16 @swissspidy
11 months ago

  • Owner swissspidy deleted

Hidden or not, if we're still displaying it in some fashion and it is still a part of core, we should still be committed to ensuring a good experience.

Is this button still a thing now with Gutenberg?

Note: See TracTickets for help on using tickets.