WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Last modified 4 years ago

#16478 reviewing defect (bug)

"Get Shortlink" button disappears if you edit the permalink

Reported by: solarissmoke's profile solarissmoke Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

Go to edit a post and change the permalink. The "Get Shortlink" button is overwritten by the AJAX response. I think it's a simple case of moving where the shortlink is added, see patch.

Attachments (4)

16478.diff​ (2.0 KB) - added by solarissmoke 14 years ago.
16478-better.diff​ (4.1 KB) - added by solarissmoke 14 years ago.
16478-3.patch​ (2.0 KB) - added by aubreypwd 11 years ago.
Moved Get Shortlink to get_sample_permalink_html
16478.4.patch​ (2.1 KB) - added by sabernhardt 4 years ago.
refresh, moving shortlink button after filter

Download all attachments as: .zip

Change History (21)

@solarissmoke
14 years ago

#1 @solarissmoke
14 years ago

  • Keywords has-patch added

@solarissmoke
14 years ago

#2 @solarissmoke
14 years ago

Actually here is a better way - no need to overwrite static data with AJAX. This would also resolve #16477.

#3 @navjotjsingh
13 years ago

  • Cc navjotjsingh@… added

This ticket was mentioned in IRC in #wordpress-dev by aubreypwd. ​View the logs.
11 years ago

@aubreypwd
11 years ago

Moved Get Shortlink to get_sample_permalink_html

#5 @aubreypwd
11 years ago

Okay, got a patch that keeps "Get Shortlink" persistent when editing. This does not fix #16477 which will have it's own patch.

This ticket was mentioned in IRC in #wordpress-dev by aubreypwd. ​View the logs.
11 years ago

#7 @aubreypwd
11 years ago

https://core.trac.wordpress.org/attachment/ticket/22980/sample_permalink.diff in #22980 is a similar (and probably better) solution.

Last edited 11 years ago by aubreypwd (previous) (diff)

This ticket was mentioned in IRC in #wordpress-dev by aubreypwd. ​View the logs.
11 years ago

#9 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 3.9

Moving to 3.9 per 7:ticket:22980.

#10 @nacin
11 years ago

  • Keywords 4.0-early added
  • Milestone changed from 3.9 to Future Release

Ran out of time, moving to 4.0.

#11 @SergeyBiryukov
10 years ago

#31933 was marked as a duplicate.

#12 follow-up: @ericlewis
9 years ago

Given that the Get Shortlink button is hidden by default since r34556, are we interested in fixing this?

#13 in reply to: ↑ 12 @DrewAPicture
9 years ago

Replying to ericlewis:

Given that the Get Shortlink button is hidden by default since r34556, are we interested in fixing this?

Hidden or not, if we're still displaying it in some fashion and it is still a part of core, we should still be committed to ensuring a good experience.

#14 @iseulde
9 years ago

  • Keywords 4.0-early removed

#15 @swissspidy
8 years ago

  • Owner set to swissspidy
  • Status changed from new to reviewing

#16 @swissspidy
6 years ago

  • Owner swissspidy deleted

Hidden or not, if we're still displaying it in some fashion and it is still a part of core, we should still be committed to ensuring a good experience.

Is this button still a thing now with Gutenberg?

@sabernhardt
4 years ago

refresh, moving shortlink button after filter

#17 @sabernhardt
4 years ago

I do not find the shortlink within the block editor panel.

In case fixing this is still desirable in the Classic Editor, I refreshed the patch.

Note: See TracTickets for help on using tickets.