Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#16489 closed defect (bug) (fixed)

HTML tags img, pre are cut out from comments

Reported by: advanpix's profile advanpix Owned by: ryan's profile ryan
Milestone: 3.1 Priority: normal
Severity: major Version: 3.0.5
Component: Comments Keywords:
Focuses: Cc:

Attachments (3)

3.0.diff (718 bytes) - added by nacin 14 years ago.
For the 3.0 branch with a new nightly.
3.1.diff (644 bytes) - added by nacin 14 years ago.
For 3.1 final.
akismet.diff (508 bytes) - added by nacin 14 years ago.
Possible Akismet hotfix.

Download all attachments as: .zip

Change History (11)

#1 @advanpix
14 years ago

I think I found the problem

In 3.0.5 file wp-includes/default-filters.php line 35 looks like:

foreach ( array( 'term_description', 'link_description', 'link_notes', 'user_description', 'comment_text' ) as $filter ) {

Just removing bold text and "," before it fixes the bug.

3.0.4 has this line without 'comment_text' - and it was working fine.

#2 @ocean90
14 years ago

  • Owner set to ryan
  • Status changed from new to reviewing

Related Changeset: [17400]

#3 @nacin
14 years ago

It's the difference in the surrounding code from [17192] to [17400] that bit us. We're looking at options.

@nacin
14 years ago

For the 3.0 branch with a new nightly.

@nacin
14 years ago

For 3.1 final.

@nacin
14 years ago

Possible Akismet hotfix.

#5 @nacin
14 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [17421]) Only run kses on comment_text in the admin. Use wp_kses_post instead of wp_kses_data for a better balance between security and flexibility. fixes #16489 for the 3.0 branch.

#6 @nacin
14 years ago

(In [17422]) Use wp_kses_post instead of wp_kses_data for a better balance between security and flexibility. fixes #16489 for trunk.

#7 @nacin
14 years ago

(In [17423]) Use wp_kses_post instead of wp_kses_data for a better balance between security and flexibility. fixes #16489 for the 3.1 branch.

#8 @nacin
14 years ago

  • Milestone changed from Awaiting Review to 3.1
Note: See TracTickets for help on using tickets.