Make $sample_permalink_html human-readable on Edit Post screen

[linuxologos]

If the permalink contains words with non-latin characters (for example the permalink structure is /%category%/%postname%/ and the assigned category is non-English) the $sample_permalink_html, which is echoed by ​edit-form-advanced.php, is not human readable on Edit Post screen (below the title). The editable part of the permalink (the one that comes from the title of the post) is readable.

$sample_permalink_html should be urldecoded at some stage before echoed.

Screenshot attached.

[linuxologos]

Same permalink, urldecoded.

[scribu]

That is actually the text you would get if you were to copy/paste from the browser's location bar.

I was going to say that we should try to fix the slug sanitization, but since all letters can be non-ascii, like in the screenshot, we should fix this instead.

[SergeyBiryukov]

Also, when using an IDN domain, sample permalink displays it in Punycode. It should be human-readable too.

[SergeyBiryukov]

Replying to scribu:

That is actually the text you would get if you were to copy/paste from the browser's location bar.

In Opera and Safari an URL is copied in human-readable form.

[linuxologos]

16496.patch​ urldecodes $sample_permalink_html upon definition.
16496.2.patch​ urldecodes $sample_permalink_html just before being echoed.

The latter can affect the Shortlink part and may not be desirable.

A third solution would be to alter the get_sample_permalink_html() function in wp-admin/includes/post.php, but it doesn't sound as the best solution.

The local $sample_permalink_html in wp-admin/edit-form-advanced.php is definitely intended to be printed on screen, so it can and should be human-readable.

[chriscct7]

Seems to work for me.
@linuxologos is this still broken for you in WordPress 4.0?

[johnbillion]

This is still an issue. It doesn't affect the post slug, just the rest of the permalink (eg. a when using a permastructure which includes the category name, and the post is in a category with punycode in its slug).

16496.3.patch​ urldecodes the permalink in the most appropriate place.

[johnbillion]

In 30364:

Decode the sample permalink shown to the user. This avoids showing encoded non-Latin characters in the sample permalink.

Fixes #16496
Props linuxologos