WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 8 years ago

#16498 closed enhancement (fixed)

simpler printing for "lostpassword" link

Reported by: ktdreyer Owned by: SergeyBiryukov
Milestone: 3.6 Priority: low
Severity: minor Version:
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

There's no need to have two lines that print the same "lostpassword" link in in wp-login.php. Skip the "else" and just print it.

Attachments (4)

lostpassword.patch (1.0 KB) - added by ktdreyer 10 years ago.
even better, with the negative mark in the right place
16498.diff (994 bytes) - added by MikeHansenMe 9 years ago.
Removes duplicate from code.
16498.2.patch (1.4 KB) - added by bpetty 8 years ago.
16498.3.patch (1.4 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (9)

@ktdreyer
10 years ago

even better, with the negative mark in the right place

#1 @markjaquith
10 years ago

  • Milestone changed from Awaiting Review to Future Release

@MikeHansenMe
9 years ago

Removes duplicate from code.

@bpetty
8 years ago

#2 @bpetty
8 years ago

  • Milestone changed from Future Release to 3.6
  • Priority changed from normal to low
  • Type changed from defect (bug) to enhancement

16498.diff is actually incorrect since there are actually 3 conditions here, not two. See 16498.2.patch, where I've made this code a little more clear.

#3 @SergeyBiryukov
8 years ago

The "Intentionally empty" section (as labeled in 16498.2.patch) was introduced in [6612]. We can rewrite the condition so that there's no need for it.

16498.3.patch is the refreshed lostpassword.patch, which I guess simplifies the logic in the most obvious way.

#4 @SergeyBiryukov
8 years ago

  • Keywords commit added

#5 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23336:

Simplify the logic for printing "Lost your password?" link. props ktdreyer. fixes #16498.

Note: See TracTickets for help on using tickets.