wp_list_filter() no longer watches for $list to be an array

[nacin]

In 3.0, wp_filter_object_list() returned early if $list was not an array.

Now the call gets passed right to wp_list_filter(), which no longer does the check.

Seen in the wild at ​http://wordpress.org/support/topic/wordpress-31-rc4-warning-invalid-argument-supplied-for-foreach?replies=3.

Can probably just patch wp_filter_object_list() rather than the new wp_list_filter().

[nacin]

Patch handles the issue higher up the stack, where the check was originally.

[scribu]

Why not handle it lower down?

[nacin]

I just feel like fixing the regression. No need to hand-hold regarding arrays if wp_list_filter() requires an array.

[nacin]

No, it's not minor. It's a regression that generates errors of E_WARNING.

[scribu]

Ok, fine.

[nacin]

Checks in both spots.

[nacin]

New patch per IRC. Second checks can't hurt.

[ryan]

(In [17427]) Return early if list is not an array. Props nacin. fixes #16499 for trunk

[ryan]

(In [17428]) Return early if list is not an array. Props nacin. fixes #16499 for 3.1