WordPress.org

Make WordPress Core

Opened 9 years ago

Last modified 5 months ago

#16502 reviewing enhancement

Quick Edit contents should only be rendered if quick edit button in actions after filtering

Reported by: wyrfel Owned by: chriscct7
Milestone: Priority: normal
Severity: normal Version: 3.0.4
Component: Quick/Bulk Edit Keywords: has-patch
Focuses: Cc:
PR Number:

Description

_the_post() has a static call to get_inline_data() to generate the quick_edit content. This happens even if after running the (undocumented) 'post_row_actions' filters the Quick-Edit link ($actionsinline hide-if-no-js?) is not amongst the actions anymore.

Prefixing the get_inline_data() call with

if (isset($actions['inline hide-if-no-js'])

would be a simple solution, enabling people to cancel the performance-impacting quick-edit form generation alltogether.

Attachments (1)

16502.diff (652 bytes) - added by garyc40 9 years ago.
simple patch

Download all attachments as: .zip

Change History (6)

#1 @wyrfel
9 years ago

Ooops, second closing bracket is missing above.

#2 @nacin
9 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

@garyc40
9 years ago

simple patch

#3 @SergeyBiryukov
9 years ago

  • Keywords has-patch added; quick edit filters removed

#4 @chriscct7
5 years ago

  • Severity changed from minor to normal

#5 @chriscct7
4 years ago

  • Owner set to chriscct7
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.