WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#16532 closed defect (bug) (fixed)

Network Admin update bubbles should check permissions

Reported by: nacin Owned by: ryan
Milestone: 3.2 Priority: low
Severity: minor Version: 3.1
Component: Network Admin Keywords: 3.2-early has-patch
Focuses: multisite Cc:

Description

It's not uncommon especially in a multisite install for various update capabilities to be denied. We should suppress the bubbles in this case, considering the pages don't show any information once visited, as those are cap-checked.

Attachments (2)

16532.diff (6.2 KB) - added by nacin 3 years ago.
16532.2.diff (10.0 KB) - added by ryan 3 years ago.
For wp-admin/menu.php too

Download all attachments as: .zip

Change History (8)

nacin3 years ago

comment:1 garyc403 years ago

Related, possibly duplicated? #14447

comment:2 nacin3 years ago

That's for the non-network admin. Both should be applied.

comment:3 nacin3 years ago

  • Keywords 3.2-early has-patch added
  • Milestone changed from Awaiting Review to Future Release

comment:4 nacin3 years ago

  • Milestone changed from Future Release to 3.2

ryan3 years ago

For wp-admin/menu.php too

comment:5 ryan3 years ago

Patch avoids doing update checks in menu.php and calculating the plugin count twice.

comment:6 ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [17822]:

Don't fetch update info our show update bubbles if the user does not have install caps. Props nacin. fixes #16532

Note: See TracTickets for help on using tickets.