Plugins page table layout seems skewed

[donalmacarthur]

On the Plugins page, the table layout seems to be a little skewed. Comparing 3.05 and 3.1-RC-4, the 'Plugins' column in the release candidate version is significantly wider - maybe 40% of the total table width. I first noticed this in 3.1-RC-3 - I'm not sure if it goes back any further.

Anyway, it's just a styling issue, but there's a lot of empty space there, especially if you're viewing the dashboard on a wide screen. I presume this isn't an intentional change, but if it is, it isn't scaling very attractively at wider resolutions.

I've taken a look in the latest versions of Chrome and Firefox, plus IE8, and the page is displaying identically in all of them, so it isn't a browser issue.

[ocean90]

A screenshot would be nice.

[nacin]

Confirmed. 3.0: ​http://cl.ly/3I052K3L2a3O2e2B250v. 3.1: ​http://cl.ly/3C172f253r1930060A2q.

It does seem like a waste of space. With a patch, we can probably squeeze it into 3.1 or ship it with 3.1.1.

I spy an unrelated string regression. #16543

[garyc40]

fix plugin and theme title width in WP_Plugins_List_Table and WP_MS_Themes_List_Table

[garyc40]

Attached patch restores the css for plugin title and theme title's width in WP_Plugins_List_Table and WP_MS_Themes_List_Table. The width now depends on the size of the content of the table cell.

[nacin]

We'll need to blame this code. I specifically remember nowrap being pulled, and I wonder where the 60% came from.

[SergeyBiryukov]

60% is from [16350].

[SergeyBiryukov]

nowrap was pulled in [17116].

[nacin]

nowrap was pulled for very specific reasons, #15834. We need to make sure the same bug doesn't return.

[nacin]

Not saying this isn't a good fix, either. The plugins table looks pretty lame on most resolutions.

[garyc40]

16536.diff​ passes scribu's test case in #15834.

I guess the reason why nowrap failed in #15834 was because plugin list table is table-layout:fixed, so nowrap breaks it. The fix should have been removing .fixed class for plugin list table instead.

[nacin]

Huh, nice catch. I didn't know that's what .fixed did for us.

[garyc40]

how it looks with lots of action links and small window size

[ryan]

Drive by note: Is /wp-admin/network/site-themes.php getting the new styling? During my brief look it still seemed to have the extra spacing. I'll look closer later. Other than that maybe non-issue it looks much better with the patch.

[ryan]

[17449] for trunk and [17450] for 3.1.