Plugin searches drop spaces with further action

[kawauso]

Steps to reproduce:

• Search for a valid plugin name with a space in it
• Activate it
• The space will be dropped from the redirected URL by wp_redirect() sanitization

[solarissmoke]

Maybe we should drop the search query var when doing other actions?

[solarissmoke]

@SergeyBiryukov the patch doesn't change anything? Steps to reproduce still cause the same issue.

[SergeyBiryukov]

Ah, I was checking the wrong installation. Feel free to make a proper one :)

[dd32]

This comes back to the usage of "...&s=$s" which translates to "...&s=Add From Server" which is obviously wrong.

Given the sheer number of redirects it's used in, This patch simply urlencodes it when it gets it from the request.

[dd32]

Bumping to 3.1 for another dev to check

[scribu]

Search for a valid plugin name with a space in it

I assume we're talking about the plugin's directory name, not the "Plugin Name:" header.

Also, is this a regression?

[solarissmoke]

Replying to scribu:

I assume we're talking about the plugin's directory name, not the "Plugin Name:" header.

No, we are talking about the plugin name, e.g. "Hello Dolly"

Also, is this a regression?

No - it's actually worse in 3.0.x because the search query is emptied, and you get this notice:

Notice: Undefined variable: total_search_plugins in wp-admin\plugins.php on line 475 

[scribu]

dd32's patch works.

[ryan]

Per bug scrub, punting to 3.2.

[kawauso]

Per chat with westi

[SergeyBiryukov]

Replying to dd32:

Given the sheer number of redirects it's used in, This patch simply urlencodes it when it gets it from the request.

Looks like urldecode() for display is not required, since $s is restored to non-encoded form in wp_reset_vars() via $wp_list_table->prepare_items().

[SergeyBiryukov]

The patch from #18148 without unnecessary urldecode()

[ryan]

In [18452]:

Fix redirects for plugin searches containing spaces in the search string. Props SergeyBiryukov. fixes #16548