wp_set_post_categories should take an integer

[ptahdunbar]

wp_set_post_categories(); can only be passed an array of cat ids. If you pass it an integer, it resets the value to the default category even though the category exists.

This happens as the if statement runs an OR check to see if the second parameter is not an array or empty. If one is true, it just goes on ahead and resets the parameter to be the default category regardless if the value was empty or a string.

Patch fixes this by strict typing the second parameter to an array. It also strict types the default category id as it was being returned as a string.

[ocean90]

Please provide a patch relative to trunk.

[ptahdunbar]

Replying to ocean90:

Please provide a patch relative to trunk.

Oops. There ya go.

[nacin]

Re-classifying this ticket. It's not a defect -- wp_set_post_categories() explicitly takes an array, so array( 3 ) rather than 3.

Other functions such as wp_set_object_terms() seem to not mind taking a scalar argument. So this looks like a fine enhancement.

[wonderboymusic]

In 25234:

Allow int to be passed in lieu of array, add append arg to wp_set_post_categories(). Adds more extensive unit tests for wp_set_post_categories().

Props ptahdunbar for initial patch.
Fixes #16550.