Make WordPress Core

Opened 13 years ago

Closed 12 years ago

#16570 closed defect (bug) (fixed)

Twenty Ten: Second row of pages needs line height

Reported by: nacin's profile nacin Owned by: lancewillett's profile lancewillett
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Edge case, definitely, but a friend using Twenty Ten for a law review site stumbled across this.

Screenshot attached.

Attachments (3)

Screen shot 2011-02-15 at 3.19.19 PM.png (12.1 KB) - added by nacin 13 years ago.
page-links-line-height.diff (389 bytes) - added by iandstewart 13 years ago.
16570.opera.png (8.5 KB) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (11)

#1 follow-up: @iandstewart
13 years ago

Attached is a patch [page-links-line-height.diff] that adds line-height to page links resolving this issue. Opera 10.6.3 will appear to crop the page-link anchor padding on the leftmost links however. Making the links inline-block elements with margin will resolve that new Opera issue -- and introduce a new display bug in IE7. :) I think this new Opera-only edge-case issue is an improvement though.

Last edited 13 years ago by iandstewart (previous) (diff)

#2 @kapeels
13 years ago

  • Keywords has-patch added

#3 @SergeyBiryukov
12 years ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from WordPress.org to 3.3

#4 @SergeyBiryukov
12 years ago

  • Milestone changed from 3.3 to WordPress.org

#5 follow-up: @mfields
12 years ago

Hello. I just noticed that this ticket has been moved to the WordPress.org milestone. What does this mean? Is there a special commit process for older bundled themes?

#6 in reply to: ↑ 1 @SergeyBiryukov
12 years ago

Replying to iandstewart:

Opera 10.6.3 will appear to crop the page-link anchor padding on the leftmost links however.

To be clear, this currently happens without the patch as well: 16570.opera.png.

The patch seems good. Tested in Firefox 14, Chrome 21, IE 8, Opera 12.

#7 in reply to: ↑ 5 @SergeyBiryukov
12 years ago

  • Keywords commit added

Replying to mfields:

I just noticed that this ticket has been moved to the WordPress.org milestone. What does this mean? Is there a special commit process for older bundled themes?

It was originally created in the WordPress.org milestone.

My guess is that as long as Twenty Ten is still a bundled theme, the ticket can be fixed via the regular commit process. However, Twenty Ten might be removed from 3.5, so I'm not sure whether the fix can make it into 3.5.

Marking for commit, per the previous comment.

#8 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [22216]:

Twenty Ten: better spacing for rows of in-content page links. Props iandstewart, fixes #16570.

Note: See TracTickets for help on using tickets.