Twenty Ten: Second row of pages needs line height

[nacin]

Edge case, definitely, but a friend using Twenty Ten for a law review site stumbled across this.

Screenshot attached.

[iandstewart]

Attached is a patch [page-links-line-height.diff] that adds line-height to page links resolving this issue. Opera 10.6.3 will appear to crop the page-link anchor padding on the leftmost links however. Making the links inline-block elements with margin will resolve that new Opera issue -- and introduce a new display bug in IE7. :) I think this new Opera-only edge-case issue is an improvement though.

[mfields]

Hello. I just noticed that this ticket has been moved to the WordPress.org milestone. What does this mean? Is there a special commit process for older bundled themes?

[SergeyBiryukov]

Replying to iandstewart:

Opera 10.6.3 will appear to crop the page-link anchor padding on the leftmost links however.

To be clear, this currently happens without the patch as well: 16570.opera.png​.

The patch seems good. Tested in Firefox 14, Chrome 21, IE 8, Opera 12.

[SergeyBiryukov]

Replying to mfields:

I just noticed that this ticket has been moved to the WordPress.org milestone. What does this mean? Is there a special commit process for older bundled themes?

It was originally created in the WordPress.org milestone.

My guess is that as long as Twenty Ten is still a bundled theme, the ticket can be fixed via the regular commit process. However, Twenty Ten might be removed from 3.5, so I'm not sure whether the fix can make it into 3.5.

Marking for commit, per the previous comment.

[lancewillett]

In [22216]:

Twenty Ten: better spacing for rows of in-content page links. Props iandstewart, fixes #16570.