WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#16571 closed defect (bug) (fixed)

Remove unused global $db_list, $global_db_list

Reported by: mitchoyoshitaka Owned by: mitchoyoshitaka
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: Database Keywords: has-patch commit 3.2-early
Focuses: Cc:

Description

In wpdb->db_connect(), we declare:

global $db_list, $global_db_list;

but don't actually use them. In fact, these variables don't show up anywhere else in the codebase.

Attachments (2)

16571.diff (402 bytes) - added by mitchoyoshitaka 5 years ago.
Trivial patch
16571.patch (419 bytes) - added by hakre 4 years ago.
Updated Patch against Ticket.

Download all attachments as: .zip

Change History (7)

@mitchoyoshitaka5 years ago

Trivial patch

comment:1 @nacin5 years ago

  • Keywords has-patch commit 3.2-early added; cleanup removed
  • Milestone changed from Awaiting Review to Future Release

The rest was killed in [15537].

comment:2 @hakre4 years ago

  • Version set to 3.1

Delete the next line as well with this second.patch / Related: #16760 (duplicate)

+1 to have this just done.

comment:3 @hakre4 years ago

Related: #16764

@hakre4 years ago

Updated Patch against Ticket.

comment:4 @nacin4 years ago

  • Milestone changed from Future Release to 3.2

comment:5 @nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17538]) Remove dead globals. props mitchoyoshitaka. fixes #16571.

Note: See TracTickets for help on using tickets.