Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#16580 closed defect (bug) (fixed)

Faq/FAQ in the admin

Reported by: SergeyBiryukov Owned by: dd32
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.0
Component: General Keywords: has-patch
Focuses: Cc:


In #15821, “Faq” on plugin pages was replaced with “FAQ”.

However when installing a plugin from the admin, it's still “Faq” there.

Attachments (3)

16580.patch (867 bytes) - added by SergeyBiryukov 5 years ago.
16580.diff (3.2 KB) - added by dd32 4 years ago.
16580.spacing.patch (2.5 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (13)

@SergeyBiryukov5 years ago

comment:1 @dd325 years ago

I'd like to move some of this business logic back to the API. Section names should come down from .org, as well as links should be absolute rather than relative.

comment:2 @nacin5 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 3.1 to 3.0

comment:3 @jane4 years ago

  • Milestone changed from Future Release to 3.4

@dd32: That's fine for long-term, but in the meantime is there any reason not to apply this consistency fix? Iterative improvement and all that.

comment:4 @dd324 years ago

Lets handle this a bit more robustly.

The attached patch adds translation support to the tabs/section names. The Section content will remain untranslated, but the section titles/tabs will be translated like the sidebar details.

I'm not sure on the context translation functions, can someone else take a peak and see if that looks right?

comment:5 @dd324 years ago

  • Owner set to dd32
  • Status changed from new to accepted

@dd324 years ago

comment:6 follow-up: @nacin4 years ago

Looks proper. Spacing alignment is way off though.

comment:7 @dd324 years ago

Spacing alignment is way off though.

Trac seems to break that for me all the time, even though it should be monospaced.. Looks better in code editors.

(Also, yes if anyone notices the variable typo, It was a testing alteration, didn't revert before patching)

comment:8 @dd324 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [19708]:

s/Faq/FAQ/ for Plugin Installer tabs, Gains Translation support for Tabs/Titles as well. Fixes #16580

comment:9 in reply to: ↑ 6 @SergeyBiryukov4 years ago

Replying to nacin:

Spacing alignment is way off though.

16580.spacing.patch removes excess whitespace. Seems more readable without it.

comment:10 @dd324 years ago

In [19710]:

Better indentation. Props SergeyBiryukov. See #16580

Note: See TracTickets for help on using tickets.