Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#16610 closed defect (bug) (fixed)

Twenty Ten 1.2 compat for WP 3.0

Reported by: nacin Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch 2nd-opinion
Focuses: Cc:


The theme directory doesn't have compatibility checks. Additionally, Twenty Ten was 3.0's default theme, so it should remain compat.


  1. get_post_format() function_exists() checks, handled in r17474 and r17469.
  1. use_default_gallery_style filter doesn't exist in 3.0.
  1. show_recent_comments_widget_style filter doesn't exist in 3.0.

Neither of these are important. I honestly don't care much if we lose compatibility on those layers. But working on patches.

Attachments (2)

16610.diff (1.1 KB) - added by nacin 5 years ago.
Untested and unconvinced.
16610.2.diff (1.1 KB) - added by nacin 5 years ago.

Download all attachments as: .zip

Change History (8)

#1 @nacin
5 years ago

Looks like we'll need to do a raw version compare for these. did_action() would work for use_default_gallery_style filter, except that it doesn't work for filters. show_recent_comments_widget_style would be pretty tough to detect otherwise.

5 years ago

Untested and unconvinced.

#2 @nacin
5 years ago

  • Keywords has-patch 2nd-opinion added

5 years ago

#3 @nacin
5 years ago

Second patch handles gallery style and ignores recent comments style.

#4 @ryan
5 years ago

Looks good.

#5 @nacin
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17477]) Back compat with the gallery_style filter in Twenty Ten. fixes #16610 for the 3.1 branch.

#6 @nacin
5 years ago

(In [17478]) Back compat with the gallery_style filter in Twenty Ten. fixes #16610 for trunk.

Note: See TracTickets for help on using tickets.