wp_dropdown_categories reqs (consistent) option_none_value

[rcain]

wp_dropdown_categories sets option_none value="-1" without any means to override, whereas other similar funcs (eg:wp_dropdown_pages) use options_none value= and also provide method to override default (option_none_value).

please could we have a consistent set of values (and options interface) to all thee dropdown funcs and save us some unnecessary and messy extra coding. thanks.

[solarissmoke]

Actually it is only wp_dropdown_pages that has an option_none_value. The other two don't. Here's a patch. It also tidies up some of the code.

[rcain]

blimey, that was quick. very many thanks solarissmoke.

you are right of course, wp_dropdown_pages is the odd one out - not wp_drop_down_categories or wp_dropdown_users - my apologies. i suppose this means we are stuck with a legacy inconsistency here, but this patch will help.

can i ask - when do patches get rolled up into core version?

[solarissmoke]

Replying to rcain:

can i ask - when do patches get rolled up into core version?

Once the senior developers have reviewed the ticket and approved the proposed changes.

PS ownership is generally assigned to/by the senior devs in charge of that component - not to the reporter.

[rcain]

Thanks for the info solarissmoke - good to know.

PS. sorry about ownership change - was accidental.

[wonderboymusic]

In 28564:

wp_dropdown_pages() allows option_none_value to be passed. Add that arg to the $defaults for wp_dropdown_users() and wp_dropdown_categories() as well.

Props solarissmoke.
Fixes #16625.

[DrewAPicture]

[28564] missed updating the inline docs for wp_dropdown_users|categories().

[DrewAPicture]

In 28570:

Add inline documentation for the option_none_value argument added to wp_dropdown_users|categories() in [28564].

Fixes #16625.