WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 8 years ago

#16629 closed defect (bug) (fixed)

Can't set super admin status if network admin email address is set first

Reported by: vegasgeek Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.1
Component: Network Admin Keywords: has-patch commit
Focuses: multisite Cc:

Description

(While testing out what I think may be a different bug, I ran in to this)

WordPress Version: 3.1 multisite

While logged in as a super admin, I went to Network Admin -> Settings and set the Network Admin Email address to match the address of an existing user on the site who was not currently granted Super Admin privileges. Then went to Network Admin -> Users, the user who has the matching email address is NOT listed as a Super Admin (I didn't expect it would be). When I clicked edit on that user, I am unable to set him as a Super Admin because it's showing me the "Super admin privileges cannot be removed because this user has the network admin email." message instead.

I tried logging in with the second account and I am not able to see the Network Admin menu options (as expected).

Yes, I realize this is a dumb order to do things in and it's not something I would normally do had I not been testing for some other weird issue I'm seeing.

Attachments (2)

16629.diff (928 bytes) - added by garyc40 10 years ago.
16629.patch (972 bytes) - added by JustinSainton 8 years ago.

Download all attachments as: .zip

Change History (7)

@garyc40
10 years ago

#1 @garyc40
10 years ago

It's definitely an edge case, might not be worth fixing, since there's been some discussion about removing network admin email option. But I attached a patch nevertheless.

#2 @SergeyBiryukov
10 years ago

  • Keywords has-patch added

#3 @nacin
8 years ago

  • Keywords needs-refresh commit added
  • Milestone changed from Awaiting Review to 3.5

Patch needs to be is_super_admin(), otherwise, good.

@JustinSainton
8 years ago

#4 @JustinSainton
8 years ago

  • Keywords needs-refresh removed

#5 @ryan
8 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21925]:

Allow granting the network admin email user super admin. Props JustinSainton, garyc40. fixes #16629

Note: See TracTickets for help on using tickets.