Blank page when db pass is incorrect

[rasheed]

Hello

While installing a clean copy of wp-3.1 am trying to produce the error when the password at wp-config.php is incorrect.

For some reason it gives me a blank page.

I tried to make the same process with older version (3.0.5) and it worked fine.

At first i thought it could be related to my server configuration but another try at a different server gave me the same result (blank page).

is it a 3.1 bug or something else ? Can anyone try it from his end ?

Thanks

[ocean90]

Is there an error message when WP_DEBUG is true in your wp-config.php?

[nacin]

He's using setup-config.php I think.

You need to comment out error_reporting(0) or change it to -1 or E_ALL to see errors.

Bumping severity as this is bad, but I'm hesitant to blame core. Can be HTTP though.

[SergeyBiryukov]

Confirmed. Broken in [15808].

[SergeyBiryukov]

Replying to nacin:

He's using setup-config.php I think.

wp-config.php is already created, so it's actually wp-admin/install.php.

[SergeyBiryukov]

The patch restores 3.0.x behaviour. The error message is displayed by wp_die() later.

[rasheed]

When WP_DEBUG is true i got this error:

=====
Warning: mysql_connect() [function.mysql-connect]: Access denied for user 'rashedes_31final'@'localhost' (using password: YES) in /home/rashedes/public_html/wordpress/3-1-final/wp-includes/wp-db.php on line 1036

Error establishing a database connection

This either means that the username and password information in your wp-config.php file is incorrect or we can't contact the database server at localhost. This could mean your host's database server is down.

• Are you sure you have the correct username and password?
• Are you sure that you have typed the correct hostname?
• Are you sure that the database server is running?

If you're unsure what these terms mean you should probably contact your host. If you still need help you can always visit the WordPress Support Forums.
=====

[ryan]

Punting to 3.2 per bug scrub.

[ryan]

Oops, punted the wrong ticket.

[westi]

I think the correct fix here is to expand this check:

if ( defined( 'WP_SETUP_CONFIG' ) ) 

to include WP_INSTALLING

As install.php will then handle as setup-config.php does.

[ryan]

Tested. Works for me and looks good.

[ryan]

(In [17536]) Don't die for failed db connects during install. Props westi. fixes #16640 for trunk

[ryan]

(In [17537]) Don't die for failed db connects during install. Props westi. fixes #16640 for 3.1

[ryan]

There are other issues. dead_db() is no longer called, meaning we get the detailed message instead of the terse message for front page loads and do not look for the custom db-error.php file.

[ryan]

db_connect() could call dead_db(), but dead_db() is an external function. wpdb cannot rely on it. That gets us into some refactoring, which I'd rather not do for 3.1.1. I'm thinking we should revert the die.

[ryan]

Revert death

[ryan]

The front page will be blank if WP_DEBUG is not set. Revert seems the way to go.

[SergeyBiryukov]

Wouldn't $this->set_charset() and $this->select() be inappropriate if $this->dbh is false? I guess it's safe to return, as in 16640.patch​.

[ryan]

(In [17546]) Don't die inside db_connect() if connection fails. Let dead_db() handle it. fixes #16640 for trunk

[ryan]

(In [17547]) Don't die inside db_connect() if connection fails. Let dead_db() handle it. fixes #16640 for 3.1

[ryan]

Replying to SergeyBiryukov:

Wouldn't $this->set_charset() and $this->select() be inappropriate if $this->dbh is false? I guess it's safe to return, as in 16640.patch​.

I added the return, retested, and committed.