WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16652 closed defect (bug) (fixed)

network_site_url() does not use main site

Reported by: ryan Owned by:
Milestone: 3.1.1 Priority: normal
Severity: normal Version: 3.1
Component: Network Admin Keywords: has-patch
Focuses: multisite Cc:

Description

network_site_url() always link to the site domain + path. network/admin.php, however, expects the network admin to be on the main site. This means the main site must be on the site domain + path. Either network_site_url() should point to main site or admin.php should redirect to domain + path rather than the main site.

Attachments (1)

16652.diff (885 bytes) - added by ryan 3 years ago.

Download all attachments as: .zip

Change History (6)

ryan3 years ago

comment:1 ryan3 years ago

  • Keywords has-patch added

comment:2 nacin3 years ago

I'm leaning toward the network admin being for the main site. It might cause funky URLs, but then you at least know which blog is running in the background (in the case of plugins etc).

comment:3 ryan3 years ago

If it is put on the domain vs. the main site, the blog id will almost always be 1. That's nice, although we might need a more convenient programmatic way of getting the id for the domain blog.

comment:4 ryan3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17510]) Anchor network and user admins at the network domain and path rather than at the main site. Makes the redirects consistent with network_admin_url(). fixes #16652 for trunk

comment:5 ryan3 years ago

(In [17511]) Anchor network and user admins at the network domain and path rather than at the main site. Makes the redirects consistent with network_admin_url(). fixes #16652 for 3.1

Note: See TracTickets for help on using tickets.