WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16659 closed defect (bug) (fixed)

Admin bar shows up when clicking preview link after theme installation

Reported by: tetele Owned by:
Milestone: 3.1.1 Priority: normal
Severity: trivial Version: 3.1
Component: Upload Keywords: has-patch commit
Focuses: Cc:

Description

Pretty self explanatory. See also #15856

Steps to reproduce:

  1. Visit /wp-admin/theme-install.php?tab=upload (Appearance > Themes > Install themes > Upload)
  2. Choose a .zip file and click Install now
  3. After theme successfully installs, click Preview link
  4. Notice admin bar. It shouldn't be there

Attachments (1)

class-wp-upgrader.php.diff (1.0 KB) - added by tetele 3 years ago.
Patch

Download all attachments as: .zip

Change History (6)

tetele3 years ago

Patch

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1.1

comment:2 aaroncampbell3 years ago

Tested patch on two trunk installs and it works fine. With the patch, the iframe src matches the one used in Appearance->Themes->Preview.

comment:3 aaroncampbell3 years ago

  • Keywords commit added

comment:4 ryan3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17502]) Mark theme preview iframe as a preview_iframe so that the admin bar doesn't show. Props tetele. fixes #16659 for trunk

comment:5 ryan3 years ago

(In [17503]) Mark theme preview iframe as a preview_iframe so that the admin bar doesn't show. Props tetele. fixes #16659 for 3.1

Note: See TracTickets for help on using tickets.