ms-load.php::get_current_site_name floads needlessly the cache

[mark-k]

wp_cache_set is being called for every call to get_current_site_name even when there is no need to update the cache - this cause slam defence warning with APC vesion 3.1.6 and generally bad for performance

the code there should probably be

function get_current_site_name( $current_site ) {
	global $wpdb;

		$current_site->site_name = wp_cache_get( $current_site->id . ':site_name', 'site-options' );
		if ( ! $current_site->site_name ) {
			$current_site->site_name = $wpdb->get_var( $wpdb->prepare( "SELECT meta_value FROM $wpdb->sitemeta WHERE site_id = %d AND meta_key = 'site_name'", $current_site->id ) );
			if ( ! $current_site->site_name )
				$current_site->site_name = ucfirst( $current_site->domain );
	    wp_cache_set( $current_site->id . ':site_name', $current_site->site_name, 'site-options' );
		}

	return $current_site;
}

[ryan]

In [18604]:

Don't set the site_name cache on every call to get_current_site_name(). Props mark-k, solarissmoke. fixes #16676