pingback xml format is false

[Jeena Paradies <spam@…>]

In /wp-includes/comment-functions.php you send a pingback this way:

$client->query('pingback.ping', array($pagelinkedfrom, $pagelinkedto) )

so it becomes:

<?xml version="1.0"?>
<methodCall>
 <methodName>pingback.ping</methodName>
 <params>
  <param><value><array><data>
   <value><string>http://example.org/test.html</string></value>
   <value><string>http://example.org/2005/09/hallo</string></value>
  </data></array></value></param>
 </params>
</methodCall>

The pingback specifications ​http://www.hixie.ch/specs/pingback/pingback says that we need such XML for a valid pingback:

<?xml version="1.0"?>
<methodCall>
 <methodName>pingback.ping</methodName>
 <params>
  <param><value><string>http://jlog.dev/test.html</string></value></param>
  <param><value><string>http://jlog.dev/2005/09/hallo</string></value></param>
 </params>
</methodCall>

If you call the method this way:

$client->query('pingback.ping', $pagelinkedfrom, $pagelinkedto)

without the array, it'll send the right XML format.

[markjaquith]

Patch for latest WP 1.6 SVN

[markjaquith]

I know nothing of the issue, but the patch I uploaded makes the change.

[masquerade]

I'll chime in and say that this is the proper fix, last arg being an array causes IXR_Value to go recursive and output the <array> and such tags. ​http://www.hixie.ch/specs/pingback/pingback-1.0#send is the important bit of the Pingback specification, it expects two args, and instead WP would be passing 1 arg as an array with the 2 args it should be sending seperately

[matt]

Do we still receivee pingbacks correctly after this change?

[matt]

(In [3078]) Follow standards in Pingback - fixes #1668

[(none)]

Milestone 2.0 deleted