$user argument of get_edit_profile_url() should be optional

[nacin]

It should default to the current user.

[nacin]

And it should be renamed from $user to $user_id, for clarity. Generally $user is a WP_User object.

[garyc40]

get_edit_profile_url() defaults to current user

[nacin]

Looking at it further, the same treatment can probably be applied to get_dashboard_url(), in fact we can just put the logic there, and pass $user_id = 0 right into get_dashboard_url().

[garyc40]

Replying to nacin:

in fact we can just put the logic there, and pass $user_id = 0 right into get_dashboard_url().

That is possible, but the $user_id passed into edit_profile_url filter would be 0 instead of an actual ID.

[garyc40]

default user for get_dashboard_url() as well

[nacin]

Good call, that's a good approach.

[nacin]

In 27260:

Make the user arguments for get_edit_profile_url() and get_dashboard_url() optional, defaulting to the current user.

props garyc40.
fixes #16686.

[nacin]

In 27265:

Fix undefined variable. see #16686.