media_sideload_image() fails on jpeg names

[numediaweb]

if you give an image file name with jpeg as extension, media_sideload_image() returns .jpe file name extension.

the problem is in the function at file: wp-admin/includes/media.php,line 565

preg_match('/[^\?]+\.(jpg|JPG|jpe|JPE|jpeg|JPEG|gif|GIF|png|PNG)/', 'test.jpeg', $matches);
echo basename($matches[0]); // returns : test.jpe

this bugs image uploading process; it doesn't allow post thumbnail generation.

[nacin]

Sounds like the ordering could be better. Try this for the regular expression instead:

/[^\?]+\.(jpg|jpeg|jpe|gif|png)/i

[numediaweb]

Thanx ncin,
I copied the same function from media.php to my custom functions and added a prefix to its name, then, just deleted the jpe|JPE|

waiting for the official fix in the next release.

[sivel]

Little variation on the patch

[sivel]

Small variation on the patch.

[nacin]

sivel's patch looks good. I also went through other instances and made us a bit more consistent in select places.

[sivel]

Updated the patch to the stepping-on-toes edition (16693.4.diff)

[georgestephanis]

Updated to current trunk to accomodate for line numbers and such

[markjaquith]

In [21219]:

Better image extension regexes, so we don't just grab the "jpe" from "jpeg" files in media_sideload_image(). props sivel. fixes #16693