WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 7 years ago

Last modified 7 years ago

#16696 closed enhancement (wontfix)

No synchronisation between "most used" and "all categories" in link edit

Reported by: solarissmoke Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

There are issues with the "all categories" and "most used" tabs when editing links:

  • Go to edit a link
  • Click on "Most used" in the category section. All the listed categories are unchecked - including the ones that are checked in the "All Categories" tab. There is no sync between the two.
  • Now check a category in the "most used" tab. Go to the "all categories" tab and you will find that the same category is now checked (as expected). Now uncheck it from the "all categories" tab. Go to "most used" and it is still checked there. The sync only works one way ( "most used" -> "all categories" ).

The first issue is because wp_popular_terms_checklist() assumes that you're using it in the context of a particular post, and sets checkedness based on whether the $post global has that term. If the $post global is empty (as when editing links), nothing is checked. I don't think we should be using wp_popular_terms_checklist() as it's context is for individual posts.

The second issue is because the IDs on the most used elements are wrong compared to what the Javascript is looking for.

Patch to follow.

Attachments (2)

16696.diff (3.5 KB) - added by solarissmoke 10 years ago.
16696.2.diff (3.5 KB) - added by solarissmoke 10 years ago.

Download all attachments as: .zip

Change History (9)

@solarissmoke
10 years ago

#1 @solarissmoke
10 years ago

  • Summary changed from Most used categories in link edit are all unchecked to No synchronisation between "most used" and "all categories" in link edit

#2 @hakre
10 years ago

  • Keywords needs-patch added; has-patch removed

Thanks for reporting the issue. I could review your patch. I see a small issue with the $number parameter you've added. It's not used at all. Please review.

After changing, please add the has-patch tag again. I've changed it for workflow reasons.

#3 @solarissmoke
10 years ago

  • Keywords has-patch added; needs-patch removed

Oops sorry, I think I changed variable names half way through writing the patch. Fixed now.

#4 @transom
7 years ago

  • Resolution set to wontfix
  • Status changed from new to closed
  • Type changed from defect (bug) to enhancement

#5 @helen
7 years ago

I'm sure it was discussed, but mind leaving a brief comment as to why the wontfix?

#6 @transom
7 years ago

Sorry about the lack of comment.

This functionality is no longer part of Core. Now part of http://wordpress.org/plugins/link-manager/

#7 @helen
7 years ago

  • Milestone Awaiting Review deleted

Ah, I see, it's specific to links.

Note: See TracTickets for help on using tickets.