WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 months ago

#16707 reopened defect (bug)

No theme is one theme

Reported by: cogmios Owned by:
Milestone: Future Release Priority: normal
Severity: minor Version: 3.1
Component: Themes Keywords: has-patch needs-testing 2nd-opinion
Focuses: Cc:

Description

If you have no themes at all it still says:

"You only have one theme installed right now. Live a little!"

Attachments (5)

themes-patch.diff (1.7 KB) - added by ldebrouwer 3 years ago.
Diff file to patch the bug
16707.2.diff (1.7 KB) - added by MikeHansenMe 19 months ago.
simpler patch with wording from original patch.
current-theme.png (17.8 KB) - added by MikeHansenMe 19 months ago.
current theme section, after removing all themes from directory.
0-themes.png (115.0 KB) - added by MikeHansenMe 3 months ago.
Screenshot with no themes
16707.3.diff (535 bytes) - added by MikeHansenMe 3 months ago.
Patch to fix the warning in previous screenshot

Download all attachments as: .zip

Change History (14)

ldebrouwer3 years ago

Diff file to patch the bug

comment:1 ldebrouwer3 years ago

  • Cc ldebrouwer added
  • Keywords has-patch needs-testing added; needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

The diff file attached above checks whether a theme is installed. If not it displays a message prompting the user to install one. It also displays a friendly message when the current theme has been removed or misplaced but alternate themes are available so the user know he/she has to switch to a working theme.

comment:2 nacin3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hey Luc, tickets are closed as fixed once the patch is committed.

comment:3 ldebrouwer3 years ago

Ok thanks, sorry for the n00b action in that case :)

comment:4 solarissmoke3 years ago

Given that the whole of Wordpress falls over when there are no themes, wouldn't it be better to put that notice say on the dashboard instead of in themes.php?

comment:5 ldebrouwer3 years ago

I guess so but that doesn't take away the fact that it should be stated on the themes page as well.

MikeHansenMe19 months ago

simpler patch with wording from original patch.

comment:7 MikeHansenMe19 months ago

  • Cc mdhansen@… added
  • Keywords 2nd-opinion added

added a new patch to accomplish the same as the original patch. This raised a question for me while viewing the themes page after the theme directory had been removed.

Should we remove the "Current Theme" section when no themes exist? (I think so)

MikeHansenMe19 months ago

current theme section, after removing all themes from directory.

comment:8 helenyhou18 months ago

  • Component changed from UI to Themes

comment:9 nacin3 months ago

  • Milestone changed from Awaiting Review to Future Release

I imagine a lot has changed here as of 3.8...

MikeHansenMe3 months ago

Screenshot with no themes

MikeHansenMe3 months ago

Patch to fix the warning in previous screenshot

Note: See TracTickets for help on using tickets.