WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 6 years ago

#16707 closed defect (bug) (worksforme)

No theme is one theme

Reported by: cogmios Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.1
Component: Themes Keywords: has-patch needs-testing
Focuses: Cc:

Description

If you have no themes at all it still says:

"You only have one theme installed right now. Live a little!"

Attachments (6)

themes-patch.diff (1.7 KB) - added by ldebrouwer 9 years ago.
Diff file to patch the bug
16707.2.diff (1.7 KB) - added by MikeHansenMe 8 years ago.
simpler patch with wording from original patch.
current-theme.png (17.8 KB) - added by MikeHansenMe 8 years ago.
current theme section, after removing all themes from directory.
0-themes.png (115.0 KB) - added by MikeHansenMe 6 years ago.
Screenshot with no themes
16707.3.diff (535 bytes) - added by MikeHansenMe 6 years ago.
Patch to fix the warning in previous screenshot
16707-4.0.png (48.3 KB) - added by MikeHansenMe 6 years ago.
current(4.1-alpha-20141017) screen when no themes

Download all attachments as: .zip

Change History (17)

@ldebrouwer
9 years ago

Diff file to patch the bug

#1 @ldebrouwer
9 years ago

  • Cc ldebrouwer added
  • Keywords has-patch needs-testing added; needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

The diff file attached above checks whether a theme is installed. If not it displays a message prompting the user to install one. It also displays a friendly message when the current theme has been removed or misplaced but alternate themes are available so the user know he/she has to switch to a working theme.

#2 @nacin
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hey Luc, tickets are closed as fixed once the patch is committed.

#3 @ldebrouwer
9 years ago

Ok thanks, sorry for the n00b action in that case :)

#4 @solarissmoke
9 years ago

Given that the whole of Wordpress falls over when there are no themes, wouldn't it be better to put that notice say on the dashboard instead of in themes.php?

#5 @ldebrouwer
9 years ago

I guess so but that doesn't take away the fact that it should be stated on the themes page as well.

@MikeHansenMe
8 years ago

simpler patch with wording from original patch.

#7 @MikeHansenMe
8 years ago

  • Cc mdhansen@… added
  • Keywords 2nd-opinion added

added a new patch to accomplish the same as the original patch. This raised a question for me while viewing the themes page after the theme directory had been removed.

Should we remove the "Current Theme" section when no themes exist? (I think so)

@MikeHansenMe
8 years ago

current theme section, after removing all themes from directory.

#8 @helenyhou
8 years ago

  • Component changed from UI to Themes

#9 @nacin
6 years ago

  • Milestone changed from Awaiting Review to Future Release

I imagine a lot has changed here as of 3.8...

@MikeHansenMe
6 years ago

Screenshot with no themes

@MikeHansenMe
6 years ago

Patch to fix the warning in previous screenshot

@MikeHansenMe
6 years ago

current(4.1-alpha-20141017) screen when no themes

#10 @MikeHansenMe
6 years ago

  • Keywords close added

I think the current status with no themes is about as good as it get considering the problem. I think this ticket is ready to close.

#11 @DrewAPicture
6 years ago

  • Keywords 2nd-opinion close removed
  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.