WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#16728 closed enhancement (invalid)

Canonical redirect ?category_name= to ?cat=

Reported by: greuben Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Canonical Keywords: has-patch close
Focuses: Cc:

Description

See #16644

Attachments (2)

16728.diff (1.1 KB) - added by greuben 4 years ago.
16728.2.diff (1.1 KB) - added by greuben 4 years ago.

Download all attachments as: .zip

Change History (10)

@greuben4 years ago

comment:1 follow-up: @scribu4 years ago

  • Owner set to scribu
  • Status changed from new to reviewing

Shouldn't there also be a check for wether pretty permalinks are on?

comment:2 @scribu4 years ago

  • Owner scribu deleted

@greuben4 years ago

comment:3 in reply to: ↑ 1 @greuben4 years ago

Replying to scribu:

Shouldn't there also be a check for wether pretty permalinks are on?

Yes added it.

comment:4 @greuben4 years ago

  • Type changed from defect (bug) to enhancement

comment:5 follow-up: @scribu4 years ago

  • Keywords close added

I've just learned from ryan that ?cat= doesn't in fact include children, while ?category_name does.

So ?cat= is different from ?category_name=. Therefore, there shouldn't be a canonical redirect.

comment:6 @scribu4 years ago

Also, if permalinks are enabled, ?cat= shouldn't redirect to /category/ either.

comment:7 in reply to: ↑ 5 @greuben4 years ago

  • Resolution set to invalid
  • Status changed from reviewing to closed

Replying to scribu:

I've just learned from ryan that ?cat= doesn't in fact include children, while ?category_name does.

So ?cat= is different from ?category_name=. Therefore, there shouldn't be a canonical redirect.

Okay, closing this as invalid.

comment:8 @scribu4 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.