WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#16733 closed defect (bug) (fixed)

[16918] Broke PATHINFO custom taxomony permalinks

Reported by: markjaquith Owned by:
Milestone: 3.1.1 Priority: high
Severity: major Version: 3.1
Component: Rewrite Rules Keywords:
Focuses: Cc:

Description (last modified by markjaquith)

[16918] fixed #15813 for built in taxonomies, but broke it for custom taxonomies. It now double-adds the index.php/ prefix to the rewrite rules.

index.php/index.php/type/([^/]+)/?$ => index.php?post_format=$matches[1]

Change History (10)

#1 @markjaquith
5 years ago

  • Description modified (diff)

#2 follow-ups: @duck_
5 years ago

Looks like patch on #16662 fixes this (along with revert of [16918])

#3 in reply to: ↑ 2 @duck_
5 years ago

Replying to duck_:

Looks like patch on #16662 fixes this (along with revert of [16918])

Unless you change the category base:

'topics/(.+?)/?$' => 'index.php?category_name=$matches[1]',

#4 @alxndr
5 years ago

  • Cc alxndr+wordpress@… added

#5 in reply to: ↑ 2 @duck_
5 years ago

Replying to duck_:

Looks like patch on #16662 fixes this (along with revert of [16918])

Obviously I'm completely failing to notice that this is only papering over the issue that with_front false doesn't work with PATHINFO permalinks (the same is true of custom post types registered with with_front => false).

/me hopes I don't quadruple post

#7 follow-up: @dd32
5 years ago

My research has yielded these results. There's more to it. Regular category permalinks were broken too.

Different Changeset there.. That'll be [15825], Setting with_front => true in the category tax registration should fix that

#8 in reply to: ↑ 7 @greuben
5 years ago

Replying to dd32:

My research has yielded these results. There's more to it. Regular category permalinks were broken too.

Different Changeset there.. That'll be [15825], Setting with_front => true in the category tax registration should fix that

Yes, with_front solves it. I've already attached a patch on ticket:16662:16662.3.diff

#9 @markjaquith
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Prevent double index.php preprend on PATHINFO custom taxonomy permalinks. Proper use of with_front. props greuben. fixes #16918. fixes #16622. see #15813. see #12659. For trunk

Version 0, edited 5 years ago by markjaquith (next)

#10 @markjaquith
5 years ago

Prevent double index.php preprend on PATHINFO custom taxonomy permalinks. Proper use of with_front. props greuben. fixes #16773. fixes #16662. see #15813. see #12659. For 3.1

Last edited 5 years ago by markjaquith (previous) (diff)
Note: See TracTickets for help on using tickets.