WordPress.org

Make WordPress Core

Changes between Initial Version and Version 17 of Ticket #16751


Ignore:
Timestamp:
03/05/11 04:10:23 (3 years ago)
Author:
dd32
Comment:

"Don't work" means I have a confirmed defect in the plugins screen of the dashboard.

In the future, mentioning the actual problem in the description is best practice, and attacking developers for changing something is not ideal either. Had you have tested 3.1, or any of your plugin users had tested 3.1, it would've been identified at the time and fixed.

As it is, The problem is that @ is unexpected input, and does not fit with the WordPres "standard" plugin header, whilst the plugin still "Works" it's just the author details are not read correctly, That being said, That style of headers is something worth while supporting, as it is, a very small percentage of plugins use it, which explains why it was missed in the testing.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16751

    • Property Status changed from new to reopened
    • Property Summary changed from Plugins Don't Work in WP 3.1 to phpdoc breaks plugins in WP 3.1
    • Property Milestone changed from Awaiting Review to 3.1.1
    • Property Keywords has-patch added
    • Property Type changed from defect (bug) to enhancement
  • Ticket #16751 – Description

    initial v17  
    1 function get_file_data() is no longer compatible with most of the headers in my plugins.  I've seen some pretty dumb changes in WordPress before, but this is the kind that makes me want to not use it again. 
     1As of  #15193, some plugin header styles such as those used [http://plugins.trac.wordpress.org/browser/simple-shortlinks/trunk/shortlinks.php#L12 here] fail to parse correctly (Specifically, `@author: Blah`) 
    22 
    3 Go ahead and close this as not a bug.  I'll just stick with version 2.9.  :( 
     3Ideally, we should support PHP-Doc style comment structures for plugin headers as well as the "standard" style.