PHP5-port - srand()

[hakre]

No need to seed the random number generator.

See ​srand() for details.

Related: #16753

[hakre]

Probably this just was forgotten

[crrobi01]

• Removed srand()
• There's no reason to do floor(rand()) when rand() always returns an integer.
• Renamed $emailNOSPAMaddy to $email_no_spam_addy to match ​Coding Standards
• Replaced "$i = $i + 1" with "$i++" which is more common in WordPress

[SergeyBiryukov]

Version field indicates when the enhancement was initially suggested.

[c3mdigital]

Closing as maybe later. See: ​http://make.wordpress.org/core/2011/03/23/code-refactoring/

[SergeyBiryukov]

Actually, removing srand() and floor() seems valid here. It's removing obsolete and redundant code, not just a readability enhancement.

[dd32]

Agreed, Lets just clean this entire function up.

[dd32]

In 25055:

Remove some PHP4-ness from the antispambot() function, and update it to match some modern coding standards. Props hakre and crrobi01 for initial patches. Fixes #16754

[buffler]

It's not going to affect the functionality but it does look like there's a typo in the docblock - line 1487 reads @param int $extra_entrpoy rather than @param int $extra_entropy

[dd32]

In 25058:

Correct a typo in a docblock in [25055]. Props buffler. See #16754

[duck_]

I'd argue that $extra_entropy is a misleading name for the variable. 16754.diff​ switches to $hex_encoding and uses array style character access instead of substr().

[dd32]

I agree that it's not exactly a great name, and am fine with it being changed (anything was better than $mailto)

At first, $hex_encoding doesn't feel right, because it just randomly hex's characters, it doesn't turn it on for the entire link, but at the same time, it does what it says on the box, enables some hex encoding.

[dd32]

In 25146:

Use a better variable name in antispambot() introduced with [25055]. Props duck_ Fixes #16754