PHP5-port - Access Violations on wpdb::$prefix

[hakre]

The to be accessed privately member wpdb::$prefix is accessed publicly in multiple places.

This would do fatal errors if the property would be ported to PHP 5 with the documented behavior.

The errorneous usage in the places in question might reveal that implementation details were missed because the prefix can differ on multi-site setups which is not technically guaranteed when accessing the private member.

The private member was only used "read-only" inside the class. Probably this is a documentation issue. It's set set_prefix() and set_blog_id() functions (only) and always to the result of wpdb::get_blog_prefix().

[hakre]

Use of get_blog_prefix()

[hakre]

Fix in documentation

[hakre]

The second one is just for the case that it might be argued that this is issue with documentation (instead with the code). However I do not recommend to use it.

[hakre]

Related: #16762 (for wpdb::$base_prefix)

[hakre]

Related: #16764

[kawauso]

Could someone take the reviewing status off? Cheers.

[c3mdigital]

Closing as maybe later. See: ​http://make.wordpress.org/core/2011/03/23/code-refactoring/

[SergeyBiryukov]

16756.2.patch​ looks like a valid inline documentation fix to me.

[wonderboymusic]

​http://core.trac.wordpress.org/ticket/22234#comment:5

[nacin]

We also have $wpdb->get_blog_prefix() (with no arguments). Maybe all usage of $wpdb->prefix should start wrapping that function — potentially even having it set via a magic getter. (They essentially are already linked, any methods that change the prefix sets $wpdb->prefix.)

At that point, should $wpdb->prefix even be recommended? I'd wonder if keeping it as @access private (as in, "please don't use it") is OK.

I dunno, maybe ryan has an opinion as the two of us shaped a lot of this back in 3.0.

[SergeyBiryukov]

Replying to nacin:

We also have $wpdb->get_blog_prefix() (with no arguments). Maybe all usage of $wpdb->prefix should start wrapping that function — potentially even having it set via a magic getter.

Then maybe 16756.patch​ is the way to go.

[ryan]

We have get_blog_prefix(). Might as well use it.

[hakre]

We have get_blog_prefix() used in 16756.patch​

[nacin]

In 25615:

Use the wpdb method instead of $wpdb->prefix.

props hakre.
fixes #16756.