Removal of wpdb::supports_collation()

[hakre]

In 2.5 wpdb::supports_collation() had been introduced and used in a single place inside core, that was wp-admin/includes/schema.php r6199. In r8740 the use has been switched over to wpdb::has_cap() which was 2.7 then.

As usual there might be third party code that is still making use of this function but since it can be ported backwards compatible to wpdb::has_cap( 'collation' ) for wp 2.7 and above, and it is documented to be used only at one place (see the phpdoc of the function) and it was actually used in only one place over the years and already has been subject to improvement, I suggest to just remove it.

Third party code will do a straight fatal error that makes it easy to locate where to apply a change:

$wpdb->supports_collation() -> $wpdb->has_cap( 'collation' )

[hakre]

It might make sense to deprecate the function first but that might be considered to be bloat in this case. Feedback appreceated.

[hakre]

Related: #16764

[dd32]

What's this got to do with PHP5?

And other than breaking stuff, Why remove it? (_depecated_function() perhaps, but remove, no?)

[westi]

I don't see any point in removing this deprecating maybe yes.

Removing PHP5 for subject because this is nothing to do with PHP5

[hakre]

Replying to dd32:

What's this got to do with PHP5?

While refactoring the whole wpdb class I ran over this function as a probably removal candidate from the class's interface. The related ticket is #16764, an interface has been written down in ​16764.patch

[hakre]

Replying to dd32:

And other than breaking stuff, Why remove it? (_depecated_function() perhaps, but remove, no?)

As far as core is concerned this doesn't break anything. The proposed usage for third party code is to use alternative has_cap function anyway so - as written - chance is very likely that this removal won't break anything.

Additionally as written, deprecation has been concerned if it makes sense. You have not provided much information to make a dedicated decision which of the two alternatives should be preferred.

If you can shed some more light into this issue this would be really appreciated.

Writing a patch that contains the call to deprecated function is rather trivial. The actual decision is more important in my eyes.

[hakre]

deprecated function call

[westi]

Please update the patch to adhere to the Coding style and to include the arguments directly in the function call rather than defining variables for single usage.

[hakre]

Replying to westi:

Please update the patch to adhere to the Coding style and to include the arguments directly in the function call rather than defining variables for single usage.

Updated the patch, please review.

[pento]

Refreshed patch. Let's deprecate this thing.

[nacin]

In [21470]:

Deprecate wpdb::supports_collation() in favor of wpdb::has_cap().

props hakre, pento. fixes #16757.