#16761 closed defect (bug) (fixed)
php notices with the_widget().
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Widgets | Keywords: | has-patch |
Focuses: | Cc: |
Description
the_widget() generates php notices when not passed $args and $instance parameters. To my knowledge these parameters are intended to be optional. To reproduce:
- Define WP_DEBUG as true in wp_config.php
- Please the following code in any template file in your active theme:
<?php the_widget( 'WP_Widget_Archives' ); the_widget( 'WP_Widget_Calendar' ); the_widget( 'WP_Widget_Categories' ); the_widget( 'WP_Nav_Menu_Widget' ); the_widget( 'WP_Widget_Links' ); the_widget( 'WP_Widget_Meta' ); the_widget( 'WP_Widget_Pages' ); the_widget( 'WP_Widget_Recent_Comments' ); the_widget( 'WP_Widget_Recent_Posts' ); the_widget( 'WP_Widget_RSS' ); the_widget( 'WP_Widget_Search' ); the_widget( 'WP_Widget_Tag_Cloud' ); the_widget( 'WP_Widget_Text' ); ?>
I have attached a patch that I believe eliminates all notices. Please let me know your thoughts.
Attachments (2)
Change History (14)
#1
@
14 years ago
- Milestone changed from Awaiting Review to 3.2
- Owner set to nacin
- Status changed from new to accepted
#2
@
14 years ago
It seems like even an empty title should be passed through the widget_title
filter.
#4
follow-up:
↓ 9
@
14 years ago
I'm not sure that these are really widget bugs.
If these notices only show when widgets are loaded via the_widget
then it may be because these items are required configuration for the widget that the theme should be providing.
If we do make the changes here we can revert - [17672]
#9
in reply to:
↑ 4
@
13 years ago
- Milestone changed from Future Release to 3.3
Replying to westi:
If these notices only show when widgets are loaded via
the_widget
then it may be because these items are required configuration for the widget that the theme should be providing.
Most of these widgets have default configurations and should fall back to them properly.
As I mentioned in #18595, Google shows a lot of results with these notices, so it would be nice to fix them.
Refreshed the patch for 3.3.
Fixes notices in widgets.