WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 3 years ago

#16767 closed enhancement (fixed)

PHP5-port - De-Reference as needed.

Reported by: hakre Owned by:
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

In PHP5 objects and references to objects aren't what those were in PHP4.

Attachments (3)

16767.patch (39.9 KB) - added by hakre 5 years ago.
handpicked (where applicable) &new -> new, &$this -> $this
16767.2.patch (43.1 KB) - added by hakre 4 years ago.
Patch against trunk, merged with latest 16661 patch
16767.3.patch (63.1 KB) - added by hakre 4 years ago.
Most callbacks and functions definitions (PHP uses copy on write, no need to optimize what needs no optimisation)

Download all attachments as: .zip

Change History (12)

@hakre5 years ago

handpicked (where applicable) &new -> new, &$this -> $this

comment:1 @scribu5 years ago

  • Owner set to scribu
  • Status changed from new to reviewing

It would be good to coordinate with #16661

Last edited 4 years ago by scribu (previous) (diff)

comment:2 @scribu5 years ago

  • Owner scribu deleted

comment:3 @nacin4 years ago

  • Type changed from defect (bug) to enhancement

comment:4 @hakre4 years ago

Reviewed #16661 for the first time.

@hakre4 years ago

Patch against trunk, merged with latest 16661 patch

@hakre4 years ago

Most callbacks and functions definitions (PHP uses copy on write, no need to optimize what needs no optimisation)

comment:5 @hakre4 years ago

Reference: #13319

comment:6 @ryan4 years ago

(In [17573]) Assigning the return value of new by reference is deprecated. Props hakre. see #16767

comment:7 @hakre4 years ago

Related: #17443

comment:8 @ocean904 years ago

Related: #18237

comment:9 @nacin3 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.