Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 15 years ago

Closed 14 years ago

#16767 closed enhancement (fixed)

PHP5-port - De-Reference as needed.

Reported by:	hakre	Owned by:
Priority:	normal	Milestone:	3.2
Component:	General	Version:	3.1
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

In PHP5 objects and references to objects aren't what those were in PHP4.

Attachments (3)

16767.patch (39.9 KB ) - added by hakre 15 years ago.: handpicked (where applicable) &new -> new, &$this -> $this
16767.2.patch (43.1 KB ) - added by hakre 15 years ago.: Patch against trunk, merged with latest 16661 patch
16767.3.patch (63.1 KB ) - added by hakre 15 years ago.: Most callbacks and functions definitions (PHP uses copy on write, no need to optimize what needs no optimisation)

Download all attachments as: .zip

Change History (12)

@hakre
15 years ago

Attachment 16767.patch added

handpicked (where applicable) &new -> new, &$this -> $this

#1 @scribu
15 years ago

Owner set to scribu
Status new → reviewing

It would be good to coordinate with #16661

Last edited 15 years ago by scribu (previous) (diff)

#2 @scribu
15 years ago

Owner scribu removed

#3 @nacin
15 years ago

Type defect (bug) → enhancement

#4 @hakre
15 years ago

Reviewed #16661 for the first time.

@hakre
15 years ago

Attachment 16767.2.patch added

Patch against trunk, merged with latest 16661 patch

@hakre
15 years ago

Attachment 16767.3.patch added

Most callbacks and functions definitions (PHP uses copy on write, no need to optimize what needs no optimisation)

#5 @hakre
15 years ago

Reference: #13319

#6 @ryan
15 years ago

(In [17573]) Assigning the return value of new by reference is deprecated. Props hakre. see #16767

#7 @hakre
15 years ago

Related: #17443

#8 @ocean90
15 years ago

Related: #18237

#9 @nacin
14 years ago

Milestone Awaiting Review → 3.2
Resolution → fixed
Status reviewing → closed

Note: See TracTickets for help on using tickets.

Download in other formats: