PHP5-port - Class Constructors Review for 3.2

[hakre]

Related: #10861, #14920 and others.

@ryan: my name counts as anybody else' one.

[hakre]

originating by hakre @ #10861

[hakre]

some in wp-includes/capabilities.php

[hakre]

@todo WP_User tries to return a non-object. Throw an exception?

[hakre]

wpdb PHP4 constructor removal, Eelated: #16764; X-Eef: #14672, [15537]

[hakre]

cache.php constructor; originating by hakre @ #10861

[hakre]

Related: #16782 - contains constructor changes for WP_Error, interesting case for having the constructor "returning" something (e.g. empty string) which is not possible and can be seen in other constructors inside wordpress as well.

[ryan]

(In [17604]) Remove PHP4 constructors. Props hakre. see #16768

[Jayjdk]

Removes PHP4 constructor for WP_Embed in media.php

[ryan]

(In [17631]) Remove PHP4 constructor. Props Jayjdk. see #16768

[ocean90]

16768.class-oembed.patch should be the last one.

[scribu]

widgets.16768.diff​ moves widget classes to __construct().

The PHP4 constructor in WP_Widget can't be removed because it's likely used by plugins.

Patch also fixes the way WP_Widget::WP_Widget() calls __construct(), avoiding an ​endless loop.

[ryan]

(In [17654]) Remove PHP4 constructor. Props ocean90. see #16768

[ryan]

(In [17655]) Remove PHP4 constructors. Props scribu. fixes #16768

[ocean90]

16768.alot.patch: Some more. Needs a second review, I couldn't find any problems with that.

[ryan]

(In [17771]) Constructor cleanup. Props ocean90. fixes #16768

[ampt]

​text_diff.16768.2.patch: Found a few more in Text Diff classes

[ocean90]

Thanks for your patch, but I asked ryan yesterday and he tolds me, to leave third party classes as it is.

[ampt]

Ok no problem, thanks.

[ampt]

Sorry, one more thing. Does this count?
​text_diff.16768.3.patch

Fix the call to the parent's constructor in WP_Text_Diff_Renderer_Table

I am getting error's with a subclass WP_Text_Diff_Renderer_Table.

[ocean90]

Interesting, yes that works. I leave that, because I thought, that it won't work because of the missing __construct() in the parent class.

No errors before and after your patch. Which errors do you mean?

[ampt]

The errors (before the patch) are from a plugin which uses a subclass of WP_Text_Diff_Renderer so its not a part of core, but this affects anyone wanting to subclass WP_Text_Diff_Renderer.

As far as PHP5 is concerned a constructor is a constructor, it doesn't seem to matter if the constructor is defined as the class name or defined as __construct.

[markjaquith]

Neat.

[markjaquith]

In [17781]:

More constructor cleanup. Props ampt. see #16768

[jane]

Freeze!

[hakre]

Related: #20801, #18975