Context Navigation

← Previous Ticket
Next Ticket →

#16768 closed enhancement (fixed)

PHP5-port - Class Constructors Review for 3.2

Reported by:	hakre	Owned by:
Priority:	normal	Milestone:	3.2
Component:	General	Version:	3.1
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

Related: #10861, #14920 and others.

@ryan: my name counts as anybody else' one.

Attachments (12)

16768.patch (493 bytes ) - added by hakre 15 years ago.: originating by hakre @ #10861
16768.2.patch (1.1 KB ) - added by hakre 15 years ago.: some in wp-includes/capabilities.php
16768.3.patch (998 bytes ) - added by hakre 15 years ago.: wpdb PHP4 constructor removal, Eelated: #16764; X-Eef: #14672, [15537]
16768.4.patch (489 bytes ) - added by hakre 15 years ago.: cache.php constructor; originating by hakre @ #10861
media_php4_constructor.patch (509 bytes ) - added by Jayjdk 15 years ago.: Removes PHP4 constructor for WP_Embed in media.php
16768.class-oembed.patch (479 bytes ) - added by ocean90 15 years ago.
widgets.16768.diff (6.3 KB ) - added by scribu 15 years ago.
16768.alot.patch (23.4 KB ) - added by ocean90 15 years ago.
text_diff.16768.patch (1.4 KB ) - added by ampt 15 years ago.
text_diff.16768.2.patch (3.0 KB ) - added by ampt 15 years ago.
text_diff.16768.3.patch (398 bytes ) - added by ampt 15 years ago.
mixed-constructor-test.php (203 bytes ) - added by markjaquith 15 years ago.: Neat.

Download all attachments as: .zip

Change History (34)

@hakre
15 years ago

Attachment 16768.patch added

originating by hakre @ #10861

@hakre
15 years ago

Attachment 16768.2.patch added

some in wp-includes/capabilities.php

#1 @hakre
15 years ago

Keywords dev-feedback added

@todo WP_User tries to return a non-object. Throw an exception?

#2 @hakre
15 years ago

Summary Class Constructors Review for 3.2 → PHP5-port - Class Constructors Review for 3.2

@hakre
15 years ago

Attachment 16768.3.patch added

wpdb PHP4 constructor removal, Eelated: #16764; X-Eef: #14672, [15537]

@hakre
15 years ago

Attachment 16768.4.patch added

cache.php constructor; originating by hakre @ #10861

#3 @hakre
15 years ago

Related: #16782 - contains constructor changes for WP_Error, interesting case for having the constructor "returning" something (e.g. empty string) which is not possible and can be seen in other constructors inside wordpress as well.

#4 @nacin
15 years ago

Type defect (bug) → enhancement

#5 @ryan
15 years ago

Milestone Awaiting Review → 3.2

#6 @ryan
15 years ago

(In [17604]) Remove PHP4 constructors. Props hakre. see #16768

@Jayjdk
15 years ago

Attachment media_php4_constructor.patch added

Removes PHP4 constructor for WP_Embed in media.php

#7 @ryan
15 years ago

(In [17631]) Remove PHP4 constructor. Props Jayjdk. see #16768

@ocean90
15 years ago

Attachment 16768.class-oembed.patch added

#8 @ocean90
15 years ago

16768.class-oembed.patch should be the last one.

@scribu
15 years ago

Attachment widgets.16768.diff added

#9 @scribu
15 years ago

widgets.16768.diff moves widget classes to __construct().

The PHP4 constructor in WP_Widget can't be removed because it's likely used by plugins.

Patch also fixes the way WP_Widget::WP_Widget() calls __construct(), avoiding an endless loop.

#10 @ryan
15 years ago

(In [17654]) Remove PHP4 constructor. Props ocean90. see #16768

#11 @ryan
15 years ago

Resolution → fixed
Status new → closed

(In [17655]) Remove PHP4 constructors. Props scribu. fixes #16768

@ocean90
15 years ago

Attachment 16768.alot.patch added

#12 @ocean90
15 years ago

Keywords dev-feedback removed
Resolution fixed
Status closed → reopened

16768.alot.patch: Some more. Needs a second review, I couldn't find any problems with that.

#13 @ryan
15 years ago

Resolution → fixed
Status reopened → closed

(In [17771]) Constructor cleanup. Props ocean90. fixes #16768

@ampt
15 years ago

Attachment text_diff.16768.patch added

@ampt
15 years ago

Attachment text_diff.16768.2.patch added

#14 @ampt
15 years ago

Resolution fixed
Status closed → reopened

text_diff.16768.2.patch: Found a few more in Text Diff classes

#15 @ocean90
15 years ago

Resolution → fixed
Status reopened → closed

Thanks for your patch, but I asked ryan yesterday and he tolds me, to leave third party classes as it is.

#16 @ampt
15 years ago

Ok no problem, thanks.

@ampt
15 years ago

Attachment text_diff.16768.3.patch added

#17 @ampt
15 years ago

Resolution fixed
Status closed → reopened

Sorry, one more thing. Does this count?
text_diff.16768.3.patch

Fix the call to the parent's constructor in WP_Text_Diff_Renderer_Table

I am getting error's with a subclass WP_Text_Diff_Renderer_Table.

#18 @ocean90
15 years ago

Interesting, yes that works. I leave that, because I thought, that it won't work because of the missing __construct() in the parent class.

No errors before and after your patch. Which errors do you mean?

#19 @ampt
15 years ago

The errors (before the patch) are from a plugin which uses a subclass of WP_Text_Diff_Renderer so its not a part of core, but this affects anyone wanting to subclass WP_Text_Diff_Renderer.

As far as PHP5 is concerned a constructor is a constructor, it doesn't seem to matter if the constructor is defined as the class name or defined as __construct.

Last edited 15 years ago by ampt (previous) (diff)

@markjaquith
15 years ago

Attachment mixed-constructor-test.php added

Neat.

#20 @markjaquith
15 years ago

In [17781]:

More constructor cleanup. Props ampt. see #16768

#21 @jane
15 years ago

Resolution → fixed
Status reopened → closed

Freeze!

#22 @hakre
14 years ago

Related: #20801, #18975

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#16768 closed enhancement (fixed)

PHP5-port - Class Constructors Review for 3.2

Description

Attachments (12)

Change History (34)

@hakre 15 years ago

@hakre 15 years ago

#1 @hakre 15 years ago

#2 @hakre 15 years ago

@hakre 15 years ago

@hakre 15 years ago

#3 @hakre 15 years ago

#4 @nacin 15 years ago

#5 @ryan 15 years ago

#6 @ryan 15 years ago

@Jayjdk 15 years ago

#7 @ryan 15 years ago

@ocean90 15 years ago

#8 @ocean90 15 years ago

@scribu 15 years ago

#9 @scribu 15 years ago

#10 @ryan 15 years ago

#11 @ryan 15 years ago

@ocean90 15 years ago

#12 @ocean90 15 years ago

#13 @ryan 15 years ago

@ampt 15 years ago

@ampt 15 years ago

#14 @ampt 15 years ago

#15 @ocean90 15 years ago

#16 @ampt 15 years ago

@ampt 15 years ago

#17 @ampt 15 years ago

#18 @ocean90 15 years ago

#19 @ampt 15 years ago

@markjaquith 15 years ago

#20 @markjaquith 15 years ago

#21 @jane 15 years ago

#22 @hakre 14 years ago

Download in other formats:

@hakre
15 years ago

@hakre
15 years ago

#1 @hakre
15 years ago

#2 @hakre
15 years ago

@hakre
15 years ago

@hakre
15 years ago

#3 @hakre
15 years ago

#4 @nacin
15 years ago

#5 @ryan
15 years ago

#6 @ryan
15 years ago

@Jayjdk
15 years ago

#7 @ryan
15 years ago

@ocean90
15 years ago

#8 @ocean90
15 years ago

@scribu
15 years ago

#9 @scribu
15 years ago

#10 @ryan
15 years ago

#11 @ryan
15 years ago

@ocean90
15 years ago

#12 @ocean90
15 years ago

#13 @ryan
15 years ago

@ampt
15 years ago

@ampt
15 years ago

#14 @ampt
15 years ago

#15 @ocean90
15 years ago

#16 @ampt
15 years ago

@ampt
15 years ago

#17 @ampt
15 years ago

#18 @ocean90
15 years ago

#19 @ampt
15 years ago

@markjaquith
15 years ago

#20 @markjaquith
15 years ago

#21 @jane
15 years ago

#22 @hakre
14 years ago