WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 8 months ago

#16781 closed enhancement (invalid)

is_wp_error() simplification

Reported by: hakre Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

please review. see #2600, [3667], is_a(), is_subclass_of()

Attachments (2)

16781.patch (529 bytes) - added by hakre 3 years ago.
w/o subclassing
16781.2.patch (539 bytes) - added by hakre 3 years ago.
with subclassing

Download all attachments as: .zip

Change History (6)

hakre3 years ago

w/o subclassing

hakre3 years ago

with subclassing

comment:1 hakre3 years ago

Related: #16782

comment:2 nacin3 years ago

  • Type changed from defect (bug) to enhancement

comment:3 hakre3 years ago

Second patch is faults, must be is_a() instead of is_subclass_of(), so first patch is already with subclassing.

comment:4 dd328 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Calling is_a() with a non-object $thing is known to have unexpected behaviours https://bugs.php.net/bug.php?id=55475

Note: See TracTickets for help on using tickets.