WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 15 years ago

#16783 closed enhancement (fixed)

Do not output title attributes with wp_list_pages()

Reported by: bergius Owned by: ryan
Priority: normal Milestone: 3.3
Component: General Version: 3.1
Severity: minor Keywords: has-patch
Cc: Focuses:

Description

Standard output from wp_list_pages() is this:

<a href="/page/" title="Page">Page</a>

The title attribute is superfluous when it's exactly the same as the page title. Will be read like "Page – Page" with a screen reader.

Can't see any reason why Wordpress should output this.

Attachments (1)

16783.diff​ (811 bytes ) - added by logiclord 16 years ago.
Title attribute removed.

Download all attachments as: .zip

Change History (10)

@logiclord
16 years ago

Title attribute removed.

#1 @logiclord
16 years ago

  • Resolution → fixed
  • Status new → closed

#2 @hakre
16 years ago

  • Resolution fixed
  • Status closed → reopened

Thanks for providing a patch.

But please keep in mind, that nothing is fixed until any changes have been committed that resolve this issue for the reporting parties.

So please don't close a ticket only because a patch was provided. That's important that things will get really fixed then. Thanks!

#3 @hakre
16 years ago

  • Keywords has-patch added

#4 @scribu
16 years ago

  • Owner set to scribu
  • Status reopened → reviewing

Related: #15046

#5 @scribu
16 years ago

  • Owner scribu removed

#6 @logiclord
16 years ago

sorry. I will keep it in mind next time :D

#7 @nacin
16 years ago

Yeah, I'd tend to agree with this. Patch looks good for what it's designed to do.

#8 @SergeyBiryukov
15 years ago

  • Milestone Awaiting Review → 3.3

#9 @ryan
15 years ago

  • Owner set to ryan
  • Resolution → fixed
  • Status reviewing → closed

In [18739]:

Do not output title attributes in the page walker since they match the anchor and are thus superfluous. Props logiclord. fixes #16783

Note: See TracTickets for help on using tickets.