Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#16783 closed enhancement (fixed)

Do not output title attributes with wp_list_pages()

Reported by: bergius's profile bergius Owned by: ryan's profile ryan
Milestone: 3.3 Priority: normal
Severity: minor Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:


Standard output from wp_list_pages() is this:

<a href="/page/" title="Page">Page</a>

The title attribute is superfluous when it's exactly the same as the page title. Will be read like "Page – Page" with a screen reader.

Can't see any reason why Wordpress should output this.

Attachments (1)

16783.diff (811 bytes) - added by logiclord 13 years ago.
Title attribute removed.

Download all attachments as: .zip

Change History (10)

13 years ago

Title attribute removed.

#1 @logiclord
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#2 @hakre
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for providing a patch.

But please keep in mind, that nothing is fixed until any changes have been committed that resolve this issue for the reporting parties.

So please don't close a ticket only because a patch was provided. That's important that things will get really fixed then. Thanks!

#3 @hakre
13 years ago

  • Keywords has-patch added

#4 @scribu
13 years ago

  • Owner set to scribu
  • Status changed from reopened to reviewing

Related: #15046

#5 @scribu
13 years ago

  • Owner scribu deleted

#6 @logiclord
13 years ago

sorry. I will keep it in mind next time :D

#7 @nacin
13 years ago

Yeah, I'd tend to agree with this. Patch looks good for what it's designed to do.

#8 @SergeyBiryukov
13 years ago

  • Milestone changed from Awaiting Review to 3.3

#9 @ryan
13 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from reviewing to closed

In [18739]:

Do not output title attributes in the page walker since they match the anchor and are thus superfluous. Props logiclord. fixes #16783

Note: See TracTickets for help on using tickets.