CategoryWalker, if cat_name is empty, do not append the empty a tag to the output

[samo9789]

If the theme is customized to skip some categories by doing something like add_filter('list_cats', 'hideSomeCatgory') and returning a null or an empty string as cat name, the CategoryWalker will append an empty html element to the output

[samo9789]

Hi,

This is my first contribution to an existing open source project. I hope I respected the ticket creation and patch submission process and that this can help improve Wordpress. I hope someone will review this correction.

Take care,
samo9789

[samo9789]

patch for described minor bug

[boonebgorges]

samo9789 - Thanks for the patch, and sorry for the delay in response.

In general, I would not recommend the use of the 'list_cats' filter for this purpose - if you want to prevent terms from being displayed in, say, wp_list_categories(), you're much better off passing an 'exclude' parameter to that function, or filtering 'get_terms'. That being said, I think you're right that there's no good reason to generate an empty element.

[boonebgorges]

In 31025:

In Walker_Category, don't generate list elements for empty cat names.

This change allows the 'list_cats' filter to be used to suppress certain
items in category lists, without creating invalid or superfluous markup.

Props samo9789.
Fixes #16792.