Duplicate strings in XML-RPC

[pavelevap]

In class-wp-xmlrpc-server.php file there are 2 almost same strings:

"You are not allowed to upload files to this site."

"You are not allowed to upload files on this site."

Maybe they should be the same and we can save one string?

[ericmann]

I'd agree. Any chance you can save us a lookup and reference line numbers?

[pavelevap]

Sorry, I wanted to create patch but was not sure which variant is right.

Lines 1525 and 2969.

[ericmann]

Now that I've looked through the file again, there are a lot of duplicate strings ... not just those two. What's the value of reducing the number of duplicates? What's the damage in leaving them?

[pavelevap]

No damage, I guess.

But easier work for translators and smaller .mo file (and so less memory used).

[ericmann]

Normalize strings

[ericmann]

I misread your original ticket :-( I agree with you 100% and have posted a patch. Since both sections are checking the same permission, they should output the same error message:

You are not allowed to upload files to this site.

[nacin]

(In [17554]) Change this string to one that already exists. props ericmann, fixes #16806.