WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#16806 closed defect (bug) (fixed)

Duplicate strings in XML-RPC

Reported by: pavelevap Owned by:
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

In class-wp-xmlrpc-server.php file there are 2 almost same strings:

"You are not allowed to upload files to this site."

"You are not allowed to upload files on this site."

Maybe they should be the same and we can save one string?

Attachments (1)

16806.diff (568 bytes) - added by ericmann 10 years ago.
Normalize strings

Download all attachments as: .zip

Change History (8)

#1 @ericmann
10 years ago

I'd agree. Any chance you can save us a lookup and reference line numbers?

#2 @pavelevap
10 years ago

Sorry, I wanted to create patch but was not sure which variant is right.

Lines 1525 and 2969.

#3 @ericmann
10 years ago

Now that I've looked through the file again, there are a lot of duplicate strings ... not just those two. What's the value of reducing the number of duplicates? What's the damage in leaving them?

#4 @pavelevap
10 years ago

No damage, I guess.

But easier work for translators and smaller .mo file (and so less memory used).

@ericmann
10 years ago

Normalize strings

#5 @ericmann
10 years ago

  • Keywords has-patch added
  • Version set to 3.1

I misread your original ticket :-( I agree with you 100% and have posted a patch. Since both sections are checking the same permission, they should output the same error message:

You are not allowed to upload files to this site.

#6 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17554]) Change this string to one that already exists. props ericmann, fixes #16806.

#7 @nacin
10 years ago

  • Milestone changed from Awaiting Review to 3.2
Note: See TracTickets for help on using tickets.