hide-if-no-js not working on Most Used link

[deepak.seth]

The Most Used link of hierarchical taxonomy like Category is shown on Post page with Java script disabled, which should get hidden by default.
The tab has hide-if-no-js class but it gets overridden with display:inline somehow.

Also shows on WordPress.com sites.

[hakre]

Can you add a link on a wp.org install to reproduce it more easily?

[deepak.seth]

Replying to hakre:

Can you add a link on a wp.org install to reproduce it more easily?

To recreate the problem: disable the javascript->open the add new post page->here you can see the most used link on category widget,though i think it shouldn't be visible and it doesn't work either.

[solarissmoke]

make sure -no-js styling doesn't get overridden by more specific instructions elsewhere

[solarissmoke]

It's getting overridden in wp-admin.css by

#side-sortables .category-tabs li, #side-sortables .add-menu-item-tabs li {
	display: inline
}

Actually this happens in quite a few places. We need to bump the importance of the no-js styling.

[nacin]

I'm comfortable with this patch. Early 3.3.

[azaozz]

I'm generally very much against using !important anywhere but perhaps it's warranted in this case.

[azaozz]

In [18664]:

Make hide-if-no-js and hide-if-js important, props solarissmoke, fixes #16810

[solarissmoke]

Turns out this causing some undesirable side-effects, maybe !important is a bad idea after all. See #18656.

[SergeyBiryukov]

So this probably should be fixed on a case-by-case basis.

16810.patch​ fixes the initial reported issue with the "Most Used" link.

[solarissmoke]

When I looked into this the first time I found at least 3-4 other cases where the same thing was happening. I can't remember where they were now but will see if I can find them.

Fixing them on a case-by-case basis is going to be tedious to maintain, because any change to the specificity of the selectors in future could cause the problem to resurface. That said, I can't think of a less awkward solution either.

[azaozz]

In [18668]:

Revert [18664] and handle any similar cases separately, props SergeyBiryukov, fixes #16810, fixes #18656

[duck_]

In [19179]:

Only hide "Most Used" category tab when the body has .no-js class. See #16810, fixes #19129.