WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#16813 closed enhancement (fixed)

PHP5-port - Deprecate wp_clone()

Reported by: hakre Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

wp_clone() is not needed any longer. php natives can do better and php 4 does not needs to be supported any longer.

let's just deprecate it (hey, that could have been done already for 3.1).

Next to deprecation, the version check is obviously luxury (for trunk).

See Object Cloning

Related: #8844, #8146, [9740]

Reference: #13480

Attachments (1)

16813.patch (3.2 KB) - added by hakre 3 years ago.
Oh so fine.

Download all attachments as: .zip

Change History (10)

hakre3 years ago

Oh so fine.

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

comment:2 hakre3 years ago

Related: #16920 - contains a patch that deprecates the wp_clone() function (only).

Last edited 3 years ago by hakre (previous) (diff)

comment:3 hakre3 years ago

Related: #16661, #16917, #16918

Last edited 3 years ago by hakre (previous) (diff)

comment:4 ryan3 years ago

  • Milestone changed from Future Release to 3.2

comment:5 ryan3 years ago

The APC and memcached object cache drop-ins do not use wp_clone() so moving it from load.php to deprecated.php should be safe.

comment:6 ryan3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17613]) Deprecate wp_clone(). Call clone directly. Props hakre. fixes #16813

comment:7 nacin3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

FIXME the next two lines of code are not necessary and should be removed.

Why?

Either it should be deemed as such (by a committer) or such comments should be removed until there's a decision made.

Otherwise it is confusing for people who see it.

comment:8 aaroncampbell3 years ago

That does seem like a comment that belongs as a Trac ticket for a future release instead of in the code.

comment:9 nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from reopened to closed

In [18321]:

Remove undiscussed FIXME from add_option. fixes #16813.

Note: See TracTickets for help on using tickets.