PHP5-port - Deprecate wp_clone()

[hakre]

wp_clone() is not needed any longer. php natives can do better and php 4 does not needs to be supported any longer.

let's just deprecate it (hey, that could have been done already for 3.1).

Next to deprecation, the version check is obviously luxury (for trunk).

See ​Object Cloning

Related: #8844, #8146, [9740]

Reference: #13480

[hakre]

Oh so fine.

[hakre]

Related: #16920 - contains a patch that deprecates the wp_clone() function (only).

[hakre]

Related: #16661, #16917, #16918

[ryan]

The APC and memcached object cache drop-ins do not use wp_clone() so moving it from load.php to deprecated.php should be safe.

[ryan]

(In [17613]) Deprecate wp_clone(). Call clone directly. Props hakre. fixes #16813

[nacin]

FIXME the next two lines of code are not necessary and should be removed.

Why?

Either it should be deemed as such (by a committer) or such comments should be removed until there's a decision made.

Otherwise it is confusing for people who see it.

[aaroncampbell]

That does seem like a comment that belongs as a Trac ticket for a future release instead of in the code.

[nacin]

In [18321]:

Remove undiscussed FIXME from add_option. fixes #16813.