Context Navigation

← Previous Ticket
Next Ticket →

#16825 closed defect (bug) (fixed)

Conflict var name in _get_meta_sql

Reported by:	Rahe	Owned by:
Priority:	normal	Milestone:	3.1.1
Component:	Query	Version:	3.1
Severity:	trivial	Keywords:	has-patch commit
Cc:		Focuses:

Description

Hi,

One of the parameters is overriden in this function ( $meta_type ) and is returned in the filter.

function _get_meta_sql( $meta_query, $meta_type, $primary_table, $primary_id_column, $context = null ) {

and overriden here :

		$meta_type = isset( $q['type'] ) ? strtoupper( $q['type'] ) : 'CHAR';

This bug is blocker when you use the filter :

	return apply_filters_ref_array( 'get_meta_sql', array( compact( 'join', 'where' ), $meta_query, $meta_type, $primary_table, $primary_id_column, &$context ) );

Attachments (2)

mypatch.diff (1.7 KB ) - added by Rahe 15 years ago.: Speedy fix
16825.diff (1.5 KB ) - added by nacin 15 years ago.

Download all attachments as: .zip

Change History (8)

@Rahe
15 years ago

Attachment mypatch.diff added

Speedy fix

#1 @scribu
15 years ago

Keywords commit added

#2 @scribu
15 years ago

Milestone Awaiting Review → Future Release
Owner set to scribu
Status new → reviewing

#3 @nacin
15 years ago

Milestone Future Release → 3.1.1

@nacin
15 years ago

Attachment 16825.diff added

#4 @scribu
15 years ago

Owner scribu removed

#5 @automattor
15 years ago

Resolution → fixed
Status reviewing → closed

(In [17530]) Avoid var name conflict in _get_meta_sql(). Fixes type var passed to get_meta_sql filter. Props Rahe, nacin. fixes #16825 for trunk

#6 @ryan
15 years ago

(In [17531]) Avoid var name conflict in _get_meta_sql(). Fixes type var passed to get_meta_sql filter. Props Rahe, nacin. fixes #16825 for 3.1

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#16825 closed defect (bug) (fixed)

Conflict var name in _get_meta_sql

Description

Attachments (2)

Change History (8)

@Rahe 15 years ago

#1 @scribu 15 years ago

#2 @scribu 15 years ago

#3 @nacin 15 years ago

@nacin 15 years ago

#4 @scribu 15 years ago

#5 @automattor 15 years ago

#6 @ryan 15 years ago