WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#16827 closed defect (bug) (fixed)

Network Users alternate row highlighting does not work properly

Reported by: nickmomrik Owned by: westi
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: Network Admin Keywords: has-patch
Focuses: multisite Cc:

Description

If you browse to wp-admin/network/users.php and mark a user (that user row must have the 'alternate' class already) as spam, the row's background will not be light red as expected. It will still be the alternate color and then the next row will now be the alternate color as well.

I've attached two possible solutions.

Attachments (6)

user-row-highlights1.diff (945 bytes) - added by nickmomrik 3 years ago.
user-row-highlights2.diff (2.2 KB) - added by nickmomrik 3 years ago.
16827.3.diff (552 bytes) - added by wpmuguru 3 years ago.
use CSS to highlight the status
colors-hacked-fixed.diff (1.8 KB) - added by westi 3 years ago.
In progress hacking
16827.4.diff (552 bytes) - added by wpmuguru 3 years ago.
16827.3.diff + fix for #faa => #faafaa
16827.5.diff (549 bytes) - added by wpmuguru 3 years ago.
16827.4.diff with #faa

Download all attachments as: .zip

Change History (19)

comment:1 westi3 years ago

  • Owner set to westi
  • Status changed from new to accepted

comment:2 scribu3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

I thought there was a guideline somewhere for never using !important in any WP css files.

comment:3 scribu3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

trac just keeps getting funkier and funkier.

comment:4 wpmuguru3 years ago

A third way to address this would be to make the .site-spammed more specific by adding .wp-list-table .site-spammed to the CSS.

wpmuguru3 years ago

use CSS to highlight the status

comment:5 westi3 years ago

With SCRIPT_DEBUG enabled I don't see this issue.

So I just think we may need to re-compress some CSS.

comment:6 westi3 years ago

Ok. It looks like the underlying bug that really needs fixing is this.

The CSS files are output in different orders with SCRIPT_DEBUG enabled/disabled - which is why the CSS for this is being overridden by other CSS.

That shouldn't happen because it makes testing of patches hard and gives different behvaiour between live/dev

westi3 years ago

In progress hacking

comment:7 westi3 years ago

I see no harm in the css changes proposed to make them more specific - in fact they are probably a good idea.

The attached patch works towards removing the hacky 'colours' style loading code and move towards using the normal en-queuing so that it works correctly with or without SCRIPT_DEBUG and the colour css gets loaded via load-styles too.

wpmuguru3 years ago

16827.3.diff + fix for #faa => #faafaa

comment:8 wpmuguru3 years ago

[16902] expanded #faa to #faafaa. #faa is the shortform of #ffaaaa. 16827.4.diff combines 16827.3.diff with a fix for the #faa.

comment:9 nacin3 years ago

Nice catch. We should move back to #faa rather than #ffaaaa for standards purposes.

wpmuguru3 years ago

16827.4.diff with #faa

comment:10 follow-up: wpmuguru3 years ago

This still does not have the 3.2 milestone on it. Is there are reason it's being left off the list?

comment:11 in reply to: ↑ 10 westi3 years ago

  • Milestone changed from Awaiting Review to 3.2

Replying to wpmuguru:

This still does not have the 3.2 milestone on it. Is there are reason it's being left off the list?

Nope. I thought I already set that when I started working on it :(

comment:12 westi3 years ago

For 3.2 I think we should just fix the CSS
The Script Loaded diversion I will raise as a separate ticket for 3.3

comment:13 westi3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [18086]:

Make the css for the row status highlighting more specific so that it works regardless of the ordering of the CSS loading. Fixes #16827 props wpmuguru.

Note: See TracTickets for help on using tickets.