Make WordPress Core

Opened 19 years ago

Closed 19 years ago

Last modified 18 years ago

#1683 closed defect (bug) (fixed)

Blogger Importer inserts comments directly

Reported by: skeltoac's profile skeltoac Owned by: ryan's profile ryan
Milestone: Priority: high
Severity: normal Version: 1.6
Component: Administration Keywords: importer
Focuses: Cc:


One last MySQL query. To speed importing and ensure the script doesn't die() on inserting comments, this diff adds circumvention of checks in wp_new_comment().

Attachments (2)

1683.diff (5.6 KB) - added by skeltoac 19 years ago.
svn diff
1683.2.diff (21.9 KB) - added by skeltoac 19 years ago.
svn diff

Download all attachments as: .zip

Change History (6)

19 years ago

svn diff

#1 @ryan
19 years ago

Actually, I'd like to bust this up into multiple functions.

wp_insert_comment() would handle the DB insertion.

wp_allow_comment() would do the flood protection, check_comment(), wp_blacklist_check(), and other checks.

wp_new_comment_notification() would live in pluggable-functions and would call wp_notify_post_author() and wp_notify_moderator.

wp_new_comment() would wrap all of these up into one call.

Importers would call wp_insert_comment() and thus avoid the comment checks and mail notifications.

wp_new_comment() would continue to be used as is.

19 years ago

svn diff

#3 @ryan
19 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2894]) wp_insert_comment(), wp_update_comment(), wp_allow_comment(), and wp_filter_comment() from skeltoac. fixes #1683

#4 @(none)
18 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.