Category Base Should be Slugified

[miklb]

Vanilla install of 3.1. Change category base to Foo Bar. Link generated is example.com/Foo Bar/cat (note the %20/space). Clicking link tries to access /FooBar/cat and 404's.

I see there are a few other tickets regarding categories, including #16662 but no specific mention of custom category base.

[scribu]

I'm surprised this wasn't caught before.

[garyc40]

What's the expected behavior here? Should we sanitize the whole thing (making it foo-bar), or just make sure the generated link and the redirection points to the same URL?

[scribu]

I would say both (the first might take care of the other, though).

[garyc40]

sanitize category_base before saving to the db

[scribu]

I think it would be safe to remove the following two lines as well:

if ( ! empty( $category_base ) ) 
  $category_base = $blog_prefix . preg_replace('#/+#', '/', '/' . str_replace( '#', '', $category_base ) );

since it's already taken care of.

[garyc40]

category base can be 'foo/bar' as well, sanitize both category base and tag base this time

[garyc40]

Seems like slashes are permitted in category_base and tag_base. Patch attached to take this into account when sanitizing slugs.

[SergeyBiryukov]

Stumbled upon this while debugging #15256.

16839.2.diff​ works with the example of "Foo Bar". However using Cyrillic characters in category base gives some strange results.

Currently Cyrillic category base is not urlencoded, but seems to work in most places, except for canonical redirect (where it's just cut, resulting in incorrect URL).

With 16839.2.diff​, "рубрика" is correctly sanitized to %d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0, however any category request returns *all* published posts.

This is what Debug Bar shows:

Request:
%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0/gallery

Matched Rewrite Rule:
%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0/(.+?)/?$

Matched Rewrite Query:
%d1%gallery&%d1%&%d0%&%d1%&%d0%&%d0%&%d0%&category_name=

[SergeyBiryukov]

#39873 was marked as a duplicate.

[audrasjb]

As per today's old ticket triage session:

This proposal still looks relevant.
Adding a bunch of workflow keywords, and leaving it in Future Release pending a new refreshed patch :)

Props @hellofromTonya @SergeyBiryukov for the discussion.