add_rewrite_rule() should accept an array for the $redirect parameter

[scribu]

The most common usage of add_rewrite_rule() looks something like this:

add_rewrite_rule( 'some/path/([^/]+)/?$', 'index.php?some_var=$matches[1]&maybe_some_flag=1' );

That's not very pretty.

Here's what it could look like instead:

add_rewrite_rule( 'some/path/([^/]+)/?$', array(
  'some_var' => '$matches[1]', 
  'maybe_some_flag' => 1
) );

In the rare case when you want to use something other than 'index.php' in the front (i.e. an external rule), you can either fall back to the old form or just use add_external_rule().

[DrewAPicture]

16840.2.diff​ updates the patch including docs and adds tests both for the add_rewrite_rule() wrapper and WP_Rewrite::add_rule().

[DrewAPicture]

16840.3.diff​ adds stricter checks in the tests after feedback from @boonebgorges.

[wonderboymusic]

In 34708:

Rewrite: allow add_rewrite_rule|WP_Rewrite::add_rule() to accept an associative array for the value of $redirect instead of requiring a query string.

Adds unit tests.

Props scribu, DrewAPicture.
Fixes #16840.

[wonderboymusic]

In 34847:

Rewrite: add tests for add_rewrite_rule().

Props DrewAPicture.
See #16840.